You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/04/20 18:44:55 UTC
Re: Review Request 46285: Windows: [3/4] `sendfile` used with the
typed error state of `Try`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46285/
-----------------------------------------------------------
(Updated April 20, 2016, 4:44 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Summary (updated)
-----------------
Windows: [3/4] `sendfile` used with the typed error state of `Try`.
Repository: mesos
Description (updated)
-------
Windows: [3/4] `sendfile` used with the typed error state of `Try`.
Diffs (updated)
-----
3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9
Diff: https://reviews.apache.org/r/46285/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 46285: Windows: [3/4] `sendfile` used with the
typed error state of `Try`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46285/#review130040
-----------------------------------------------------------
Ship it!
Committed with the following change.
3rdparty/libprocess/src/poll_socket.cpp (line 223)
<https://reviews.apache.org/r/46285/#comment193653>
`s/Failure(length.error());/return Failure(length.error());/`
- Michael Park
On April 20, 2016, 4:44 p.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46285/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 4:44 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: [3/4] `sendfile` used with the typed error state of `Try`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9
>
> Diff: https://reviews.apache.org/r/46285/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>