You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cxf.apache.org by COURTAULT Francois <Fr...@gemalto.com> on 2018/10/10 10:26:43 UTC

Infinite loop in rest client

Hello,

We are using TomEE 7.0.5 or 7.1.0 which embeds cxf 3.1.15.

During stress tests, we found several threads with this pattern:
    java.lang.Thread.State: RUNNABLE
        at java.util.WeakHashMap.put(WeakHashMap.java:453)
        at java.util.Collections$SetFromMap.add(Collections.java:5461)
        at org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.initTargetClientIfNeeded(ClientImpl.java:358)

This same issue has been found by others:
http://www.adam-bien.com/roller/abien/entry/endless_loops_in_unsychronized_weakhashmap

Do you know if a fix exists for that issue ?

Best Regards.
________________________________
This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.

RE: Infinite loop in rest client

Posted by COURTAULT Francois <Fr...@gemalto.com>.
Hello Colm,

Issue created in JIRA: CXF-7869 - Infinite loop in rest client<https://issues.apache.org/jira/browse/CXF-7869>

Best Regards.

From: Colm O hEigeartaigh [mailto:coheigea@apache.org]
Sent: jeudi 11 octobre 2018 16:13
To: COURTAULT Francois <Fr...@gemalto.com>
Cc: users@cxf.apache.org
Subject: Re: Infinite loop in rest client

Yes I will fix it in CXF 3.1.x as well - please create a JIRA and I will take care of it.

Colm.

On Thu, Oct 11, 2018 at 5:06 PM COURTAULT Francois <Fr...@gemalto.com>> wrote:
Hello Colm,

Thanks for answering ...

As TomEE currently uses cxf 3.1.x, will you fix it also on this branch ?
Should I submit an issue for that  in order to keep a trace ?

Best Regards.

-----Original Message-----
From: Colm O hEigeartaigh [mailto:coheigea@apache.org<ma...@apache.org>]
Sent: jeudi 11 octobre 2018 15:42
To: users@cxf.apache.org<ma...@cxf.apache.org>
Subject: Re: Infinite loop in rest client

Hi,

I don't think so - it should be wrapped in a synchronized map, I'll fix it for CXF 3.2.7.

Colm.

On Wed, Oct 10, 2018 at 1:26 PM COURTAULT Francois < Francois.Courtault@gemalto.com<ma...@gemalto.com>> wrote:

> Hello,
>
> We are using TomEE 7.0.5 or 7.1.0 which embeds cxf 3.1.15.
>
> During stress tests, we found several threads with this pattern:
>     java.lang.Thread.State: RUNNABLE
>         at java.util.WeakHashMap.put(WeakHashMap.java:453)
>         at java.util.Collections$SetFromMap.add(Collections.java:5461)
>         at
> org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.initTargetCl
> ientIfNeeded(ClientImpl.java:358)
>
> This same issue has been found by others:
>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> adam-bien.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fadam-bien.com&data=02%7C01%7CFrancois.Courtault%40gemalto.com%7C93510d26cb204c44bd1e08d62f83a4be%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748639785629430&sdata=LbYywDQIcuZZClpXzpmZ%2BmW2WED9UBTH5t6ZYjQXxOo%3D&reserved=0>%2Froller%2Fabien%2Fentry%2Fendless_loops_in_unsychronize
> d_weakhashmap&amp;data=02%7C01%7CFrancois.COURTAULT%40gemalto.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40gemalto.com&data=02%7C01%7CFrancois.Courtault%40gemalto.com%7C93510d26cb204c44bd1e08d62f83a4be%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748639785639442&sdata=mdAUpsADnGSLyOB4qBUSsNfa08we7UUp8ixGqf6abfA%3D&reserved=0>%7Ce3
> 845131acb044c0696a08d62f805371%7C37d0a9db7c464096bfe31add5b495d6d%7C1%
> 7C0%7C636748625533322739&amp;sdata=JCx8ZVrqYb8NqaALqriEx053VyFYPxnx%2F
> gTPtLOLqBk%3D&amp;reserved=0
>
> Do you know if a fix exists for that issue ?
>
> Best Regards.
> ________________________________
> This message and any attachments are intended solely for the
> addressees and may contain confidential information. Any unauthorized
> use or disclosure, either whole or partial, is prohibited.
> E-mails are susceptible to alteration. Our company shall not be liable
> for the message if altered, changed or falsified. If you are not the
> intended recipient of this message, please delete it and notify the sender.
> Although all reasonable efforts have been made to keep this
> transmission free from viruses, the sender will not be liable for
> damages caused by a transmitted virus.
>


--
Colm O hEigeartaigh

Talend Community Coder
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcoders.talend.com&amp;data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Ce3845131acb044c0696a08d62f805371%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748625533332747&amp;sdata=%2BcJTwO54fbI38YMJSb%2B77qVJrH3EcuQpy1isRbbb%2Blk%3D&amp;reserved=0<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcoders.talend.com&data=02%7C01%7CFrancois.Courtault%40gemalto.com%7C93510d26cb204c44bd1e08d62f83a4be%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748639785649455&sdata=A0cAhN2gFUyqClMzRwzro2pFpPrnAFobc4CGx2Zeofw%3D&reserved=0>
________________________________
 This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.


--
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcoders.talend.com&data=02%7C01%7CFrancois.Courtault%40gemalto.com%7C93510d26cb204c44bd1e08d62f83a4be%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748639785649455&sdata=A0cAhN2gFUyqClMzRwzro2pFpPrnAFobc4CGx2Zeofw%3D&reserved=0>
________________________________
This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.

Re: Infinite loop in rest client

Posted by Colm O hEigeartaigh <co...@apache.org>.
Yes I will fix it in CXF 3.1.x as well - please create a JIRA and I will
take care of it.

Colm.

On Thu, Oct 11, 2018 at 5:06 PM COURTAULT Francois <
Francois.Courtault@gemalto.com> wrote:

> Hello Colm,
>
> Thanks for answering ...
>
> As TomEE currently uses cxf 3.1.x, will you fix it also on this branch ?
> Should I submit an issue for that  in order to keep a trace ?
>
> Best Regards.
>
> -----Original Message-----
> From: Colm O hEigeartaigh [mailto:coheigea@apache.org]
> Sent: jeudi 11 octobre 2018 15:42
> To: users@cxf.apache.org
> Subject: Re: Infinite loop in rest client
>
> Hi,
>
> I don't think so - it should be wrapped in a synchronized map, I'll fix it
> for CXF 3.2.7.
>
> Colm.
>
> On Wed, Oct 10, 2018 at 1:26 PM COURTAULT Francois <
> Francois.Courtault@gemalto.com> wrote:
>
> > Hello,
> >
> > We are using TomEE 7.0.5 or 7.1.0 which embeds cxf 3.1.15.
> >
> > During stress tests, we found several threads with this pattern:
> >     java.lang.Thread.State: RUNNABLE
> >         at java.util.WeakHashMap.put(WeakHashMap.java:453)
> >         at java.util.Collections$SetFromMap.add(Collections.java:5461)
> >         at
> > org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.initTargetCl
> > ientIfNeeded(ClientImpl.java:358)
> >
> > This same issue has been found by others:
> >
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> > adam-bien.com%2Froller%2Fabien%2Fentry%2Fendless_loops_in_unsychronize
> > d_weakhashmap&amp;data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Ce3
> > 845131acb044c0696a08d62f805371%7C37d0a9db7c464096bfe31add5b495d6d%7C1%
> > 7C0%7C636748625533322739&amp;sdata=JCx8ZVrqYb8NqaALqriEx053VyFYPxnx%2F
> > gTPtLOLqBk%3D&amp;reserved=0
> >
> > Do you know if a fix exists for that issue ?
> >
> > Best Regards.
> > ________________________________
> > This message and any attachments are intended solely for the
> > addressees and may contain confidential information. Any unauthorized
> > use or disclosure, either whole or partial, is prohibited.
> > E-mails are susceptible to alteration. Our company shall not be liable
> > for the message if altered, changed or falsified. If you are not the
> > intended recipient of this message, please delete it and notify the
> sender.
> > Although all reasonable efforts have been made to keep this
> > transmission free from viruses, the sender will not be liable for
> > damages caused by a transmitted virus.
> >
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcoders.talend.com&amp;data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Ce3845131acb044c0696a08d62f805371%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748625533332747&amp;sdata=%2BcJTwO54fbI38YMJSb%2B77qVJrH3EcuQpy1isRbbb%2Blk%3D&amp;reserved=0
> ________________________________
>  This message and any attachments are intended solely for the addressees
> and may contain confidential information. Any unauthorized use or
> disclosure, either whole or partial, is prohibited.
> E-mails are susceptible to alteration. Our company shall not be liable for
> the message if altered, changed or falsified. If you are not the intended
> recipient of this message, please delete it and notify the sender.
> Although all reasonable efforts have been made to keep this transmission
> free from viruses, the sender will not be liable for damages caused by a
> transmitted virus.
>


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

RE: Infinite loop in rest client

Posted by COURTAULT Francois <Fr...@gemalto.com>.
Hello Colm,

Thanks for answering ...

As TomEE currently uses cxf 3.1.x, will you fix it also on this branch ?
Should I submit an issue for that  in order to keep a trace ?

Best Regards.

-----Original Message-----
From: Colm O hEigeartaigh [mailto:coheigea@apache.org]
Sent: jeudi 11 octobre 2018 15:42
To: users@cxf.apache.org
Subject: Re: Infinite loop in rest client

Hi,

I don't think so - it should be wrapped in a synchronized map, I'll fix it for CXF 3.2.7.

Colm.

On Wed, Oct 10, 2018 at 1:26 PM COURTAULT Francois < Francois.Courtault@gemalto.com> wrote:

> Hello,
>
> We are using TomEE 7.0.5 or 7.1.0 which embeds cxf 3.1.15.
>
> During stress tests, we found several threads with this pattern:
>     java.lang.Thread.State: RUNNABLE
>         at java.util.WeakHashMap.put(WeakHashMap.java:453)
>         at java.util.Collections$SetFromMap.add(Collections.java:5461)
>         at
> org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.initTargetCl
> ientIfNeeded(ClientImpl.java:358)
>
> This same issue has been found by others:
>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> adam-bien.com%2Froller%2Fabien%2Fentry%2Fendless_loops_in_unsychronize
> d_weakhashmap&amp;data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Ce3
> 845131acb044c0696a08d62f805371%7C37d0a9db7c464096bfe31add5b495d6d%7C1%
> 7C0%7C636748625533322739&amp;sdata=JCx8ZVrqYb8NqaALqriEx053VyFYPxnx%2F
> gTPtLOLqBk%3D&amp;reserved=0
>
> Do you know if a fix exists for that issue ?
>
> Best Regards.
> ________________________________
> This message and any attachments are intended solely for the
> addressees and may contain confidential information. Any unauthorized
> use or disclosure, either whole or partial, is prohibited.
> E-mails are susceptible to alteration. Our company shall not be liable
> for the message if altered, changed or falsified. If you are not the
> intended recipient of this message, please delete it and notify the sender.
> Although all reasonable efforts have been made to keep this
> transmission free from viruses, the sender will not be liable for
> damages caused by a transmitted virus.
>


--
Colm O hEigeartaigh

Talend Community Coder
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcoders.talend.com&amp;data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Ce3845131acb044c0696a08d62f805371%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636748625533332747&amp;sdata=%2BcJTwO54fbI38YMJSb%2B77qVJrH3EcuQpy1isRbbb%2Blk%3D&amp;reserved=0
________________________________
 This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.

Re: Infinite loop in rest client

Posted by Colm O hEigeartaigh <co...@apache.org>.
Hi,

I don't think so - it should be wrapped in a synchronized map, I'll fix it
for CXF 3.2.7.

Colm.

On Wed, Oct 10, 2018 at 1:26 PM COURTAULT Francois <
Francois.Courtault@gemalto.com> wrote:

> Hello,
>
> We are using TomEE 7.0.5 or 7.1.0 which embeds cxf 3.1.15.
>
> During stress tests, we found several threads with this pattern:
>     java.lang.Thread.State: RUNNABLE
>         at java.util.WeakHashMap.put(WeakHashMap.java:453)
>         at java.util.Collections$SetFromMap.add(Collections.java:5461)
>         at
> org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.initTargetClientIfNeeded(ClientImpl.java:358)
>
> This same issue has been found by others:
>
> http://www.adam-bien.com/roller/abien/entry/endless_loops_in_unsychronized_weakhashmap
>
> Do you know if a fix exists for that issue ?
>
> Best Regards.
> ________________________________
> This message and any attachments are intended solely for the addressees
> and may contain confidential information. Any unauthorized use or
> disclosure, either whole or partial, is prohibited.
> E-mails are susceptible to alteration. Our company shall not be liable for
> the message if altered, changed or falsified. If you are not the intended
> recipient of this message, please delete it and notify the sender.
> Although all reasonable efforts have been made to keep this transmission
> free from viruses, the sender will not be liable for damages caused by a
> transmitted virus.
>


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com