You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2019/09/08 14:18:31 UTC

[incubator-superset] branch 0.34 updated (20e68c8 -> eb3cb95)

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a change to branch 0.34
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


    from 20e68c8  Set version to 0.34.0 (no rcN)
     add de21a7f  Fix: There was an issue fetching the favorite status of this dashboard #6824 (#8013)
     add 85f959f  [fix] Allow dashboard viewer auto refresh dashboard (#8014)
     add f85ba81  [bugfix] Fix deck_polygon metric bug and update examples chart (#8025)
     add 66340f1  fix: handle case where result exists but corresponding query cannot be found (#8037)
     add 08f19f1   fix: onSave datasource raises React error (#8049)
     add 6f6e068  Set disableErrorBoundary in SuperChart to fix chart error handling (#8052)
     add 4e49b8f  Fixed Histogram visualization bug.  (#8077)
     add 20a0595  Fix to Werkzeug ProxyFix; expose ProxyFix configuration items (#8117)
     add a8b0548  Add check for calls to cache_key_wrapper (#8128)
     add 3136af1  [bugfix] fix timegrain addon regression (#8165)
     add c5249ce  Make orderby native sqla construct (#8180)
     add 92481b7  [bugfix] Correctly quote table and schema in select_star (#8181)
     add 7326f37  [feat] Add d3 legend formatting for Arc, Polygon and Scatter deck.gl maps (#7951)
     new 9e6c0ab  Update core.py (#8191)
     new 7ca58f0  adding spaces missing from string concatenations (#8126)
     new eb3cb95  fix: issues #8041 - bubble support for complex metrics (#8044)

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore                                         |  1 +
 UPDATING.md                                        | 13 ++++-
 setup.py                                           |  2 +-
 superset/__init__.py                               |  5 +-
 .../components/HeaderActionsDropdown_spec.jsx      |  8 +--
 .../components/RefreshIntervalModal_spec.jsx       |  8 +++
 .../explore/components/MetricsControl_spec.jsx     |  7 +++
 superset/assets/src/chart/ChartRenderer.jsx        |  1 +
 .../assets/src/dashboard/actions/dashboardState.js |  6 +--
 .../dashboard/components/HeaderActionsDropdown.jsx | 25 ++++++----
 .../dashboard/components/RefreshIntervalModal.jsx  | 19 +++++---
 .../src/dashboard/reducers/dashboardState.js       |  2 +-
 .../explore/components/controls/MetricsControl.jsx |  6 ++-
 .../assets/src/explore/controlPanels/DeckArc.js    |  1 +
 .../src/explore/controlPanels/DeckPolygon.js       |  2 +-
 .../src/explore/controlPanels/DeckScatter.js       |  1 +
 .../assets/src/explore/controlPanels/Separator.js  |  2 +-
 superset/assets/src/explore/controls.jsx           | 12 ++++-
 superset/assets/src/visualizations/Legend.jsx      | 30 +++++++++++-
 .../deckgl/CategoricalDeckGLContainer.jsx          |  1 +
 .../deckgl/layers/Polygon/Polygon.jsx              |  1 +
 superset/config.py                                 |  4 +-
 superset/connectors/sqla/models.py                 | 40 +++++++++++++--
 superset/db_engine_specs/athena.py                 |  2 +-
 superset/db_engine_specs/base.py                   | 57 ++++++++++++++--------
 superset/db_engine_specs/bigquery.py               |  2 +-
 superset/db_engine_specs/clickhouse.py             |  2 +-
 superset/db_engine_specs/db2.py                    |  2 +-
 superset/db_engine_specs/drill.py                  |  2 +-
 superset/db_engine_specs/druid.py                  |  2 +-
 superset/db_engine_specs/impala.py                 |  2 +-
 superset/db_engine_specs/kylin.py                  |  2 +-
 superset/db_engine_specs/mssql.py                  |  2 +-
 superset/db_engine_specs/mysql.py                  |  2 +-
 superset/db_engine_specs/oracle.py                 |  2 +-
 superset/db_engine_specs/pinot.py                  |  4 +-
 superset/db_engine_specs/postgres.py               |  2 +-
 superset/db_engine_specs/presto.py                 |  2 +-
 superset/db_engine_specs/snowflake.py              |  2 +-
 superset/db_engine_specs/sqlite.py                 |  2 +-
 superset/db_engine_specs/teradata.py               |  2 +-
 superset/examples/deck.py                          | 50 +++++++++++++++----
 superset/views/core.py                             | 13 +++--
 superset/viz.py                                    | 22 ++++++---
 tests/db_engine_specs_test.py                      | 35 +++++++------
 tests/model_tests.py                               | 28 +++++++++--
 tests/sqla_models_tests.py                         | 20 +++++++-
 47 files changed, 339 insertions(+), 119 deletions(-)


[incubator-superset] 02/03: adding spaces missing from string concatenations (#8126)

Posted by vi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 0.34
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 7ca58f0212e07e6b20f69092c2ca02fc3300ab28
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Aug 27 10:37:40 2019 -0700

    adding spaces missing from string concatenations (#8126)
---
 superset/assets/src/explore/controlPanels/Separator.js | 2 +-
 superset/assets/src/explore/controls.jsx               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/assets/src/explore/controlPanels/Separator.js b/superset/assets/src/explore/controlPanels/Separator.js
index 6611aef..df80834 100644
--- a/superset/assets/src/explore/controlPanels/Separator.js
+++ b/superset/assets/src/explore/controlPanels/Separator.js
@@ -31,7 +31,7 @@ export default {
   controlOverrides: {
     code: {
       default: '####Section Title\n' +
-      'A paragraph describing the section' +
+      'A paragraph describing the section ' +
       'of the dashboard, right before the separator line ' +
       '\n\n' +
       '---------------',
diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
index ae673de..a3049d3 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -1480,7 +1480,7 @@ export const controls = {
     renderTrigger: true,
     default: true,
     description: (
-      'Whether to apply filters as they change, or wait for' +
+      'Whether to apply filters as they change, or wait for ' +
       'users to hit an [Apply] button'
     ),
   },


[incubator-superset] 01/03: Update core.py (#8191)

Posted by vi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 0.34
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 9e6c0ab7a77c03bd46700080eef52ab38a1f0577
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Sat Sep 7 23:32:17 2019 -0700

    Update core.py (#8191)
---
 superset/views/core.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 7c09b44..b0776b3 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2410,10 +2410,7 @@ class Superset(BaseSupersetView):
         )
         if rejected_tables:
             return json_error_response(
-                security_manager.get_table_access_error_msg(
-                    "{}".format(rejected_tables)
-                ),
-                status=403,
+                security_manager.get_table_access_error_msg(rejected_tables), status=403
             )
 
         payload = utils.zlib_decompress_to_string(blob)


[incubator-superset] 03/03: fix: issues #8041 - bubble support for complex metrics (#8044)

Posted by vi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 0.34
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit eb3cb955747dd4e27ee653faa5b11a835ae4d0b6
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Wed Aug 14 09:27:18 2019 -0700

    fix: issues #8041 - bubble support for complex metrics (#8044)
---
 superset/viz.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/superset/viz.py b/superset/viz.py
index 22b9e72..5aac00b 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -966,7 +966,9 @@ class BubbleViz(NVD3Viz):
         self.series = form_data.get("series") or self.entity
         d["row_limit"] = form_data.get("limit")
 
-        d["metrics"] = list(set([self.z_metric, self.x_metric, self.y_metric]))
+        d["metrics"] = [self.z_metric, self.x_metric, self.y_metric]
+        if len(set(self.metric_labels)) < 3:
+            raise Exception(_("Please use 3 different metric labels"))
         if not all(d["metrics"] + [self.entity]):
             raise Exception(_("Pick a metric for x, y and size"))
         return d