You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2007/08/13 10:36:16 UTC

[PATCH] Fix warning message in merge test

Hi,

I am attaching a patch to fix the doc string of 
"merge_to_out_of_date_target" function in merge_tests.py, which has some 
capitalized characters in it.

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix warning message in merge test

Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Hyrum K. Wright wrote:
> Senthil Kumaran S wrote:
>> Senthil Kumaran S wrote:
>>> I am attaching a patch to fix the doc string of
>>> "merge_to_out_of_date_target" function in merge_tests.py, which has
>>> some capitalized characters in it.
>> Sorry, I forgot to attach the patch :( Doing it now.
> 
> Hi Senthil,
> Thanks for your recent patches.  I've noticed, though, that you haven't
> included any log messages with your patches, per our patch submission
> guidelines, found here:
> http://subversion.tigris.org/hacking.html#patches  A good log message
> helps reviewers understand the purpose of your patch, and increases the
> likelihood that it will be applied.  Instructions for writing log
> messages can be found here:
> http://subversion.tigris.org/hacking.html#log-messages
> 
> Could you resend your outstanding patches, with a log message included
> for each?

Hello again. :)

markphip just pointed out to me that you've been including your log
messages as attachments, so I withdraw my comment about including log
messages.  Sorry about that, and thanks for including log messages!

(It may help to include them in the body of the mail so that folks like
myself don't miss them.)

Thanks again for the work!

-Hyrum (who really ought not to be working this early in the morning...)


Re: [PATCH] Fix warning message in merge test

Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Senthil Kumaran S wrote:
> Senthil Kumaran S wrote:
>> I am attaching a patch to fix the doc string of
>> "merge_to_out_of_date_target" function in merge_tests.py, which has
>> some capitalized characters in it.
> 
> Sorry, I forgot to attach the patch :( Doing it now.

Hi Senthil,
Thanks for your recent patches.  I've noticed, though, that you haven't
included any log messages with your patches, per our patch submission
guidelines, found here:
http://subversion.tigris.org/hacking.html#patches  A good log message
helps reviewers understand the purpose of your patch, and increases the
likelihood that it will be applied.  Instructions for writing log
messages can be found here:
http://subversion.tigris.org/hacking.html#log-messages

Could you resend your outstanding patches, with a log message included
for each?

Thanks,
-Hyrum


Re: [PATCH] Fix warning message in merge test

Posted by Kamesh Jayachandran <ka...@collab.net>.
Thanks Senthil.

Committed at r26050.

With regards
Kamesh Jayachandran
Senthil Kumaran S wrote:
> Senthil Kumaran S wrote:
>> I am attaching a patch to fix the doc string of 
>> "merge_to_out_of_date_target" function in merge_tests.py, which has 
>> some capitalized characters in it.
>
> Sorry, I forgot to attach the patch :( Doing it now.
>
> Thank You.
>
> -- 
> Senthil Kumaran S
> http://www.stylesen.org/
> ------------------------------------------------------------------------
>
>   

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix warning message in merge test

Posted by Senthil Kumaran S <se...@collab.net>.
Senthil Kumaran S wrote:
> I am attaching a patch to fix the doc string of 
> "merge_to_out_of_date_target" function in merge_tests.py, which has some 
> capitalized characters in it.

Sorry, I forgot to attach the patch :( Doing it now.

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/