You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2013/03/14 13:51:28 UTC
svn commit: r1456408 -
/subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c
Author: rhuijben
Date: Thu Mar 14 12:51:27 2013
New Revision: 1456408
URL: http://svn.apache.org/r1456408
Log:
* subversion/libsvn_wc/wc_db_update_move.c
(tc_editor_delete): Add ### comment marking an implementation problem.
Modified:
subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c
Modified: subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c?rev=1456408&r1=1456407&r2=1456408&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c (original)
+++ subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c Thu Mar 14 12:51:27 2013
@@ -1227,6 +1227,11 @@ tc_editor_delete(void *baton,
svn_pool_destroy(iterpool);
}
+ /* ### We might be shadowing other nodes here, so this delete
+ is not generally safe. See op-depth-test.c move_retract(),
+ for a few cases where this currently breaks the working copy
+ by not adding base-deleted nodes in its place. */
+
/* Deleting the ROWS is valid so long as we update the parent before
committing the transaction. */
SVN_ERR(svn_sqlite__get_statement(&stmt, b->wcroot->sdb,