You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/03/16 03:00:26 UTC
[kudu-CR] [security] fixed memory leak in Krb5CallToStatus
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6411
Change subject: [security] fixed memory leak in Krb5CallToStatus
......................................................................
[security] fixed memory leak in Krb5CallToStatus
Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
---
M src/kudu/security/init.cc
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/6411/1
--
To view, visit http://gerrit.cloudera.org:8080/6411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] fixed memory leak in Krb5CallToStatus
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.
Change subject: [security] fixed memory leak in Krb5CallToStatus
......................................................................
[security] fixed memory leak in Krb5CallToStatus
Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Reviewed-on: http://gerrit.cloudera.org:8080/6411
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/security/init.cc
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [security] fixed memory leak in Krb5CallToStatus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] fixed memory leak in Krb5CallToStatus
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6411/1/src/kudu/security/init.cc
File src/kudu/security/init.cc:
PS1, Line 128: {
> nit: No need curly braces?
SGTM -- since the original code was written with no braces, I'll remove them.
BTW, I find that absence of braces in simple 'if' with control statements like 'return' does not give better readability, but instead -- it becomes harder to spot those 'returns'. Probably, that's why I updated this piece as well.
--
To view, visit http://gerrit.cloudera.org:8080/6411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] fixed memory leak in Krb5CallToStatus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6411
to look at the new patch set (#2).
Change subject: [security] fixed memory leak in Krb5CallToStatus
......................................................................
[security] fixed memory leak in Krb5CallToStatus
Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
---
M src/kudu/security/init.cc
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/6411/2
--
To view, visit http://gerrit.cloudera.org:8080/6411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] fixed memory leak in Krb5CallToStatus
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: [security] fixed memory leak in Krb5CallToStatus
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6411/1/src/kudu/security/init.cc
File src/kudu/security/init.cc:
PS1, Line 128: {
nit: No need curly braces?
--
To view, visit http://gerrit.cloudera.org:8080/6411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] fixed memory leak in Krb5CallToStatus
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [security] fixed memory leak in Krb5CallToStatus
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb86d31819c504cd8fd630c744c6ef775c6a499
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No