[jira] [Reopened] (SAMZA-1183) Fix TestAsyncRunLoop flaky tests

["Navina Ramesh (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SAMZA-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navina Ramesh reopened SAMZA-1183:
----------------------------------

[~spvenkat]
I am re-opening this as the tests are still failing. The one test failure I found in jenkins had this in the log:
{code}
:samza-core_2.11:test

testCommitSingleTask FAILED
    Wanted but not invoked:
    offsetManager.checkpoint(
        Partition [partition=0]
    );
    -> at org.apache.samza.task.TestAsyncRunLoop.testCommitSingleTask(TestAsyncRunLoop.java:370)

    However, there were other interactions with this mock:
    offsetManager.update(
        Partition [partition=1],
        SystemStreamPartition [testSystem, testStream, 1],
        "1"
    );
    -> at org.apache.samza.task.AsyncRunLoop$AsyncTaskWorker$6.run(AsyncRunLoop.java:527)

    offsetManager.update(
        Partition [partition=0],
        SystemStreamPartition [testSystem, testStream, 0],
        "0"
    );
    -> at org.apache.samza.task.AsyncRunLoop$AsyncTaskWorker$6.run(AsyncRunLoop.java:527)
        at org.apache.samza.task.TestAsyncRunLoop.testCommitSingleTask(TestAsyncRunLoop.java:370)

462 tests completed, 1 failed, 1 skipped
:samza-core_2.11:test FAILED
{code}

I merged it with LinkedIn internal repository. However, it simply hangs the build on hudson. So, I am not sure which test causes the build to hang. The hanging is not transient. It happens every time I try to run the build. 
I was able to pass the build successfully only after uncommenting all tests in this class.

I suggest the following:
* reverting this change even in open-source 
* remove tests that don't actually have any assertions
* Possibly, simplify tests


> Fix TestAsyncRunLoop flaky tests
> --------------------------------
>
>                 Key: SAMZA-1183
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1183
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> Due to sequence of ordering and timeout related problems in task threads created in TestAsyncRunLoop, the following tests were failing intermittently. 
> * testCommitBehaviourWhenAsyncCommitIsEnabled
> * testProcessBehaviourWhenAsyncCommitIsEnabled    
> This will track the PR and the effort associated with the change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)