You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/30 20:47:09 UTC

[GitHub] [tvm] gromero commented on a change in pull request #7772: [µTMV] apps: Fix Zephyr code example for STM32F746 boards

gromero commented on a change in pull request #7772:
URL: https://github.com/apache/tvm/pull/7772#discussion_r604420228



##########
File path: tutorials/micro/micro_tflite.py
##########
@@ -224,7 +224,7 @@
 #     from tvm.micro.contrib import zephyr
 #
 #     repo_root = subprocess.check_output(["git", "rev-parse", "--show-toplevel"], encoding='utf-8').strip()
-#     project_dir = f"{repo_root}/tests/micro/qemu/zephyr-runtime"
+#     project_dir = f"{repo_root}/apps/microtvm/zephyr/demo_runtime"

Review comment:
       @mehrdadh Sure, done for v2. I also included the new .conf file for disco board into tests/lint/check_file_type.py (I forgot it the first time and CI warned about it. BTW, I  pushed with `-f` v2 so we don't get the additional lines in the commit message when the commits are squashed. I think that's really confusing on TVM project and I'll bring it up on our next community meeting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org