[GitHub] [dubbo] wxbty commented on pull request #12329: optimize performance for MetricsFilter

["wxbty (via GitHub)" <gi...@apache.org>]

wxbty commented on PR #12329:
URL: https://github.com/apache/dubbo/pull/12329#issuecomment-1551333720

   > > ![image](https://user-images.githubusercontent.com/9292748/238859135-b48c0300-d9b0-4738-b3cb-b87fb3b418e7.png)
   > > How about cache in AbstractMetricsListener.
   > > Allocate a map to cache class is not a good idea, and this may cause classloader unable to being gc.
   > 
   > @AlbumenJ Good idea, Is this ok? ![image](https://user-images.githubusercontent.com/18413695/238893203-5b586b71-00c8-4311-b078-e9de6aeb78f4.png)
   > 
   > Tested to improve performance by 2% than cache in ReflectionUtils
   
   Would it be better to put the match method in util, and use Object for the event type? It is not the responsibility of the current class


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org