You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by aCoder2013 <gi...@git.apache.org> on 2017/05/31 06:52:08 UTC
[GitHub] incubator-rocketmq pull request #108: [ROCKETMQ-207]Correct spelling mistake...
GitHub user aCoder2013 opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/108
[ROCKETMQ-207]Correct spelling mistake in RouteInfoManager.java
There is a spelling mistake in RouteInfoManager.java, it's a little confusing and i think we should fix it.
```java
if (null == prevBrokerLiveInfo) {
log.info("new broker registerd, {} HAServer: {}", brokerAddr, haServerAddr);
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aCoder2013/incubator-rocketmq feature/correct-spelling-mistake
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit bfa7f1ac8bfac3334e6b307db4aabc66ad22f5e9
Author: SongWang <24...@qq.com>
Date: 2017-05-29T07:54:48Z
Update RouteInfoManager.java
fixed:spelling mistake
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #108: [ROCKETMQ-207]Correct spelling mistake in Rou...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/108
Thank you! Please relate JIRA link in the discriptions.
Also, there are multiple typo string literal in rocektmq code base , it's welcome to fix them in this pr too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #108: [ROCKETMQ-207]Correct spelling mistake in Rou...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/108
[](https://coveralls.io/builds/11802611)
Coverage decreased (-0.03%) to 38.632% when pulling **9422bdb38ba8871b87c4b5172f1dc08b207d901b on aCoder2013:feature/correct-spelling-mistake** into **0fe947173a85d8931b1068805713e89dbba4125a on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #108: [ROCKETMQ-207]Correct spelling mistake in Rou...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/108
[](https://coveralls.io/builds/11757925)
Coverage decreased (-0.03%) to 38.636% when pulling **bfa7f1ac8bfac3334e6b307db4aabc66ad22f5e9 on aCoder2013:feature/correct-spelling-mistake** into **0fe947173a85d8931b1068805713e89dbba4125a on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---