You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by ak...@apache.org on 2008/05/11 17:13:21 UTC

svn commit: r655322 - /directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java

Author: akarasulu
Date: Sun May 11 08:13:21 2008
New Revision: 655322

URL: http://svn.apache.org/viewvc?rev=655322&view=rev
Log:
cleanup system.outs

Modified:
    directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java

Modified: directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java?rev=655322&r1=655321&r2=655322&view=diff
==============================================================================
--- directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java (original)
+++ directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java Sun May 11 08:13:21 2008
@@ -155,12 +155,6 @@
 
         out.flush();
 
-        if ( IS_DEBUG )
-        {
-            System.out.println( ">------------------------------------------------" );
-            System.out.println( "Serialize " + entry );
-        }
-
         return baos.toByteArray();
     }
 
@@ -367,12 +361,6 @@
                 serverEntry.put( serverAttribute );
             }
 
-            if ( IS_DEBUG )
-            {
-                System.out.println( "<------------------------------------------------" );
-                System.out.println( "Deserialize " + serverEntry );
-            }
-
             return serverEntry;
         }
         catch ( ClassNotFoundException cnfe )



DIRECTORY RESEARCH: 2 second question_please reply to me individually

Posted by "U. Yeliz Eseryel" <ye...@gmail.com>.
Hi All,
How are you?

I have a question related to the research I have been doing on the Directory
project. I would appreciate if you would answer these two questions. Please
reply to me individually (not to the list) so that your answers don¹t affect
each other..

* What % of the time do YOU check in any code without mentioning what you¹ve
done in the dev listserv, and without making any updates to JIRA?

* If you have to guess, what % of the time would you say OTHERS do that?

At the end of today, I will send out this information to the listserv based
on your answers.
* How many people responded (without giving names).
* Average %¹s for both questions.

The reason why I am asking is that, I am analyzing only JIRA and developers
email listserv to understand team coordination. I am wondering if these two
resources are enough to capture the majority of software changes done by you
guys
Thank you.
Yeliz.

Re: svn commit: r655322 - /directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java

Posted by Alex Karasulu <ak...@apache.org>.
Np I just reverted.

Alex

On Sun, May 11, 2008 at 12:07 PM, Emmanuel Lecharny <el...@apache.org>
wrote:

> Hi Alex,
>
> could you revert this change and change the System.out by LOG.debug(...) ?
>
> I have done the very same thing on trunk (not committed yet), because
> those debug logs are really usefull.
>
> Thanks !
>
>
> akarasulu@apache.org wrote:
>
> > Author: akarasulu
> > Date: Sun May 11 08:13:21 2008
> > New Revision: 655322
> >
> > URL: http://svn.apache.org/viewvc?rev=655322&view=rev
> > Log:
> > cleanup system.outs
> >
> > Modified:
> >
> >  directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
> >
> > Modified:
> > directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
> > URL:
> > http://svn.apache.org/viewvc/directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java?rev=655322&r1=655321&r2=655322&view=diff
> >
> > ==============================================================================
> > ---
> > directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
> > (original)
> > +++
> > directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
> > Sun May 11 08:13:21 2008
> > @@ -155,12 +155,6 @@
> >           out.flush();
> >  -        if ( IS_DEBUG )
> > -        {
> > -            System.out.println(
> > ">------------------------------------------------" );
> > -            System.out.println( "Serialize " + entry );
> > -        }
> > -
> >         return baos.toByteArray();
> >     }
> >  @@ -367,12 +361,6 @@
> >                 serverEntry.put( serverAttribute );
> >             }
> >  -            if ( IS_DEBUG )
> > -            {
> > -                System.out.println(
> > "<------------------------------------------------" );
> > -                System.out.println( "Deserialize " + serverEntry );
> > -            }
> > -
> >             return serverEntry;
> >         }
> >         catch ( ClassNotFoundException cnfe )
> >
> >
> >
> >
> >
>
>
> --
> --
> cordialement, regards,
> Emmanuel Lécharny
> www.iktek.com
> directory.apache.org
>
>
>

Re: svn commit: r655322 - /directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java

Posted by Emmanuel Lecharny <el...@apache.org>.
Hi Alex,

could you revert this change and change the System.out by LOG.debug(...) ?

I have done the very same thing on trunk (not committed yet), because 
those debug logs are really usefull.

Thanks !

akarasulu@apache.org wrote:
> Author: akarasulu
> Date: Sun May 11 08:13:21 2008
> New Revision: 655322
>
> URL: http://svn.apache.org/viewvc?rev=655322&view=rev
> Log:
> cleanup system.outs
>
> Modified:
>     directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
>
> Modified: directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java
> URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java?rev=655322&r1=655321&r2=655322&view=diff
> ==============================================================================
> --- directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java (original)
> +++ directory/apacheds/trunk/core-entry/src/main/java/org/apache/directory/server/core/entry/ServerEntrySerializer.java Sun May 11 08:13:21 2008
> @@ -155,12 +155,6 @@
>  
>          out.flush();
>  
> -        if ( IS_DEBUG )
> -        {
> -            System.out.println( ">------------------------------------------------" );
> -            System.out.println( "Serialize " + entry );
> -        }
> -
>          return baos.toByteArray();
>      }
>  
> @@ -367,12 +361,6 @@
>                  serverEntry.put( serverAttribute );
>              }
>  
> -            if ( IS_DEBUG )
> -            {
> -                System.out.println( "<------------------------------------------------" );
> -                System.out.println( "Deserialize " + serverEntry );
> -            }
> -
>              return serverEntry;
>          }
>          catch ( ClassNotFoundException cnfe )
>
>
>
>   


-- 
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org