You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/13 10:17:49 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
weizhouapache opened a new pull request, #7092:
URL: https://github.com/apache/cloudstack/pull/7092
### Description
This PR fixes that issue new password is applied on host when update host password with update_passwd_on_host=false
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
prior to this change, this cmd command updated the host password
with this change, this cmd command did not update the host password.
(localcloud) 🐱 > update hostpassword hostid=cc83a7ed-8387-4d99-b1bf-4ded51e91aa7 password=password username=root update_passwd_on_host=false
{
"success": true
}
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383700351
<b>Trillian Build Failed (tid-5847)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383700583
<b>Trillian Build Failed (tid-5849)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383988840
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383694053
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381810565
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7092](https://codecov.io/gh/apache/cloudstack/pull/7092?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2fb9f5f) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/4bb43f7879db0d64f852d89ca959eccbb4802579?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bb43f7) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #7092 +/- ##
=========================================
Coverage 10.36% 10.37%
- Complexity 6641 6643 +2
=========================================
Files 2453 2453
Lines 242409 242409
Branches 37933 37933
=========================================
+ Hits 25135 25139 +4
+ Misses 214168 214164 -4
Partials 3106 3106
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383694719
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381696380
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7092)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7092&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7092&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7092&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7092&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7092&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7092&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7092&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7092&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383700169
<b>Trillian Build Failed (tid-5848)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1384706706
<b>Trillian test result (tid-5862)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42989 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7092-t5862-vmware-67u3.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 645.56 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381768545
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381716743
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1383989620
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1384683247
<b>Trillian test result (tid-5863)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39801 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7092-t5863-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 605.48 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381718313
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7092:
URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1384696179
<b>Trillian test result (tid-5861)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41502 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7092-t5861-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org