You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "XinyuZeng (via GitHub)" <gi...@apache.org> on 2023/03/02 07:44:31 UTC
[GitHub] [arrow-rs] XinyuZeng opened a new pull request, #3786: minor: make Parquet CLI input args consistent
XinyuZeng opened a new pull request, #3786:
URL: https://github.com/apache/arrow-rs/pull/3786
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3785.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3786: minor: make Parquet CLI input args consistent
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#issuecomment-1451890324
I think it is fine for the more complex tools to have a different argument pattern from those that take a single input file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] XinyuZeng commented on a diff in pull request #3786: minor: make Parquet CLI input args consistent
Posted by "XinyuZeng (via GitHub)" <gi...@apache.org>.
XinyuZeng commented on code in PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#discussion_r1123409578
##########
parquet/src/bin/parquet-index.rs:
##########
@@ -48,7 +48,7 @@ struct Args {
#[clap(help("Path to a parquet file"))]
file: String,
- #[clap(help("Column name to print"))]
Review Comment:
Fixed. Also made args in bloom filter CLI positional because they are not optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3786: minor: make Parquet CLI input args consistent
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#issuecomment-1452205763
I think the pyspark integration test needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] XinyuZeng commented on pull request #3786: minor: make Parquet CLI input args consistent
Posted by "XinyuZeng (via GitHub)" <gi...@apache.org>.
XinyuZeng commented on PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#issuecomment-1451852976
Positional arguments may not be well suited for tools like parquet-fromcsv and parquet-rewrite, which have too many arguments (and many file names). But for the tools that only require one file to read, I think getting rid of "-f" makes it handier. For those tools, we can make filename positional and leave other options there.
e.g.
```
parquet-read [OPTIONS] <FILE_NAME>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3786: minor: make Parquet CLI input args consistent
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#issuecomment-1453406775
Benchmark runs are scheduled for baseline = 40e2874e1d83dd8dc64981b7f4a19f894befe615 and contender = e52574c8b02410128f35d65aa92d4876b1404d6c. e52574c8b02410128f35d65aa92d4876b1404d6c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7437ac51b1004007a4de6c5bfe3650ab...db52cec92c4e48b68d55d10168e8d02b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/6ca52d9b10bb4113b3646bc254c90c11...82b44bb39a1a4a548a093cdd05f8453c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/28a82666a4f34915a06d9bd4b9136ab6...bdfc35c19b934b59b0e3fb9d7b0ddcdd/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5e50e1b365a64af7b7d1aab96e4e2cc3...74b833a8be6a4f6dad420889d97e6e55/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3786: minor: make Parquet CLI input args consistent
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#issuecomment-1453400504
Thank you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3786: minor: make Parquet CLI input args consistent
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3786: minor: make Parquet CLI input args consistent
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#issuecomment-1451829532
What do you think of unifying in the opposite direction, i.e. making the other tools take positional arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3786: minor: make Parquet CLI input args consistent
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3786:
URL: https://github.com/apache/arrow-rs/pull/3786#discussion_r1123401796
##########
parquet/src/bin/parquet-index.rs:
##########
@@ -48,7 +48,7 @@ struct Args {
#[clap(help("Path to a parquet file"))]
file: String,
- #[clap(help("Column name to print"))]
Review Comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org