You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "tuxji (via GitHub)" <gi...@apache.org> on 2023/06/12 21:19:59 UTC

[GitHub] [daffodil] tuxji commented on a diff in pull request #1032: Modify schematron validator to support relative imports

tuxji commented on code in PR #1032:
URL: https://github.com/apache/daffodil/pull/1032#discussion_r1227248329


##########
daffodil-lib/src/main/scala/org/apache/daffodil/lib/xml/DaffodilXMLLoader.scala:
##########
@@ -172,14 +174,25 @@ class DFDLCatalogResolver private ()
   }
 
   def resolveURI(uri: String): String = {
-    init

Review Comment:
   For other reviewers: the reason why the `init` call is not needed at this line is because the next line calls `resolveCommon` which also calls `init` too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org