You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "pem70 (via GitHub)" <gi...@apache.org> on 2025/10/23 23:23:45 UTC

[PR] Fix Flaky Test `CommonExceptionDataTest#should_include_code_in_json_when_code_is_not_null` [servicecomb-java-chassis]

pem70 opened a new pull request, #4992:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4992

   ### Issue
   Test `CommonExceptionDataTest#should_include_code_in_json_when_code_is_not_null` is flaky. See #4991 
   
   ### Fix
   This fix decodes the JSON and asserts the key–value pairs on a map, so the test checks semantic content instead of exact string formatting or key order. It keeps the original goal of verifying that both "code" and "message" fields have the correct values, while removing flakiness caused by unpredictable key ordering during JSON serialization.
   
   ### Checklist
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Flaky Test `CommonExceptionDataTest#should_include_code_in_json_when_code_is_not_null` [servicecomb-java-chassis]

Posted by "pem70 (via GitHub)" <gi...@apache.org>.
pem70 commented on PR #4992:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4992#issuecomment-3449556494

   已rebase, ci问题应已解决


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Flaky Test `CommonExceptionDataTest#should_include_code_in_json_when_code_is_not_null` [servicecomb-java-chassis]

Posted by "SweetWuXiaoMei (via GitHub)" <gi...@apache.org>.
SweetWuXiaoMei merged PR #4992:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org