You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/29 23:56:40 UTC
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request
#3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL,
H2, with sample data in H2
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2
URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r270597954
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/mock/AutoOnboardMockDataSource.java
##########
@@ -61,16 +61,6 @@ public AutoOnboardMockDataSource(MetadataSourceConfig metadataSourceConfig) {
@Override
public void run() {
- if (!this.datasetDAO.findAll().isEmpty()) {
Review comment:
Are these no longer required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org