[GitHub] [gobblin] umustafi commented on a diff in pull request #3700: [GOBBLIN-1837] Implement multi-active, non blocking for leader host

["umustafi (via GitHub)" <gi...@apache.org>]

umustafi commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1210688091


##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/DagActionStoreChangeEvent.avsc:
##########
@@ -23,6 +23,11 @@
     "type" : "string",
     "doc" : "flow execution id for the dag action",
     "compliance" : "NONE"
+  }, {
+    "name" : "dagAction",
+    "type" : "string",

Review Comment:
   actually in the code this is an enum, but I did not think to encode the enum in the avro schema. Overall, I see benefits of including this as an enum here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org