You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/06/16 13:22:35 UTC
[GitHub] [phoenix-queryserver] stoty opened a new pull request, #92: PHOENIX-6731 Regenerate the protobuf python classes from the Avatica …
stoty opened a new pull request, #92:
URL: https://github.com/apache/phoenix-queryserver/pull/92
…1.21 .pb file with protoc 3.19
also drop support for python 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] richardantal commented on a diff in pull request #92: PHOENIX-6731 Regenerate the protobuf python classes from the Avatica …
Posted by GitBox <gi...@apache.org>.
richardantal commented on code in PR #92:
URL: https://github.com/apache/phoenix-queryserver/pull/92#discussion_r899959002
##########
python-phoenixdb/tox.ini:
##########
@@ -14,7 +14,7 @@
# limitations under the License.
[tox]
-envlist = py27,py34,py35,py36,py37,py38
+envlist = py27,py35,py36,py37,py38
Review Comment:
shouldn't we add py39, and py310 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on a diff in pull request #92: PHOENIX-6731 Regenerate the protobuf python classes from the Avatica …
Posted by GitBox <gi...@apache.org>.
stoty commented on code in PR #92:
URL: https://github.com/apache/phoenix-queryserver/pull/92#discussion_r899984357
##########
python-phoenixdb/tox.ini:
##########
@@ -14,7 +14,7 @@
# limitations under the License.
[tox]
-envlist = py27,py34,py35,py36,py37,py38
+envlist = py27,py35,py36,py37,py38
Review Comment:
The docke image we use now is old, and does not have any newer python versions.
I'm working on finding something that is maintaned to replace it, but that's outside the scope of this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty closed pull request #92: PHOENIX-6731 Regenerate the protobuf python classes from the Avatica …
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #92: PHOENIX-6731 Regenerate the protobuf python classes from the Avatica …
URL: https://github.com/apache/phoenix-queryserver/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org