[GitHub] [kafka] mimaison commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #13195:
URL: https://github.com/apache/kafka/pull/13195#discussion_r1098805966


##########
docs/upgrade.html:
##########
@@ -19,6 +19,16 @@
 
 <script id="upgrade-template" type="text/x-handlebars-template">
 
+<h4><a id="upgrade_3_5_0" href="#upgrade_3_5_0">Upgrading to 3.5.0 from any version 0.8.x through 3.4.x</a></h4>
+
+    <h5><a id="upgrade_350_notable" href="#upgrade_350_notable">Notable changes in 3.5.0</a></h5>
+    <ul>
+        <li>The JmxTool has been migrated to the tools module.
+            As there is no wrapper script, users have to update their commands from "kafka-run-class.sh kafka.tools.JmxTool" to "kafka-run-class.sh org.apache.kafka.tools.JmxTool".

Review Comment:
   For the sake of considering all ideas, if we think renaming these classes is problematic, another option would be to have Java classes in the tools module that match the old Scala classes name and package. This should allow existing commands to keep working while not requiring core to depend on tools.
   
   I wonder if we should add scripts for all tools. That would separate the actual classes (which are not part of the public APIs) from the scripts which effectively are part of Kafka's public APIs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org