Re: [PR] Improve Patch Generation logic and add tests [directory-scimple]

["bdemers (via GitHub)" <gi...@apache.org>]

bdemers commented on code in PR #435:
URL: https://github.com/apache/directory-scimple/pull/435#discussion_r1426198499


##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/schema/Schemas.java:
##########
@@ -201,6 +202,7 @@ private static List<Schema.Attribute> createAttributes(String urn, List<Field> f
       log.debug("Attempting to set the attribute type, raw value = " + typeName);
       switch (typeName) {
         case STRING_TYPE_IDENTIFIER:
+        case STRING_TYPE:

Review Comment:
   I need to add an issue to make coverage is good here.
   These issues likely only affect Extensions, but that is still important.
   
   The issue I was seeing is one of the Test object Extensions has a list of strings. Without this fix that list was, the list was showing up as a complex type, and would not diff correctly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org