You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Weldon Washburn <we...@gmail.com> on 2007/03/03 15:41:35 UTC
[drlvm][kernel_classes] public variables of Thread.java -- does it make sense to make them private?
It looks like several fields in kernel_classes/javasrc/java/lang/Thread.java
are accessible to other kernel classes. While kernel_classes are "trusted
code", it would help modularity&reliability to make them private and supply
the necessary getters/setters.
A list of the fields:
ThreadGroup group;
boolean started;
boolean isAlive;
Object lock;
static ThreadGroup systemThreadGroup;
static ThreadGroup mainThreadGroup;
--
Weldon Washburn
Intel Enterprise Solutions Software Division
Re: [drlvm][kernel_classes] public variables of Thread.java -- does it make sense to make them private?
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
btw, you probably already realize this, but they can't be public...
On Mar 3, 2007, at 9:41 AM, Weldon Washburn wrote:
> It looks like several fields in kernel_classes/javasrc/java/lang/
> Thread.java
> are accessible to other kernel classes. While kernel_classes are
> "trusted
> code", it would help modularity&reliability to make them private
> and supply
> the necessary getters/setters.
>
> A list of the fields:
>
> ThreadGroup group;
> boolean started;
> boolean isAlive;
> Object lock;
> static ThreadGroup systemThreadGroup;
> static ThreadGroup mainThreadGroup;
>
>
> --
> Weldon Washburn
> Intel Enterprise Solutions Software Division
Re: [drlvm][kernel_classes] public variables of Thread.java -- does it make sense to make them private?
Posted by Nathan Beyer <nd...@apache.org>.
+1 Definitely
On 3/3/07, Geir Magnusson Jr. <ge...@pobox.com> wrote:
> <b>+1</b> :)
>
> geir
>
> On Mar 3, 2007, at 8:41 AM, Weldon Washburn wrote:
>
> > It looks like several fields in kernel_classes/javasrc/java/lang/
> > Thread.java
> > are accessible to other kernel classes. While kernel_classes are
> > "trusted
> > code", it would help modularity&reliability to make them private
> > and supply
> > the necessary getters/setters.
> >
> > A list of the fields:
> >
> > ThreadGroup group;
> > boolean started;
> > boolean isAlive;
> > Object lock;
> > static ThreadGroup systemThreadGroup;
> > static ThreadGroup mainThreadGroup;
> >
> >
> > --
> > Weldon Washburn
> > Intel Enterprise Solutions Software Division
>
>
Re: [drlvm][kernel_classes] public variables of Thread.java -- does it make sense to make them private?
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
<b>+1</b> :)
geir
On Mar 3, 2007, at 8:41 AM, Weldon Washburn wrote:
> It looks like several fields in kernel_classes/javasrc/java/lang/
> Thread.java
> are accessible to other kernel classes. While kernel_classes are
> "trusted
> code", it would help modularity&reliability to make them private
> and supply
> the necessary getters/setters.
>
> A list of the fields:
>
> ThreadGroup group;
> boolean started;
> boolean isAlive;
> Object lock;
> static ThreadGroup systemThreadGroup;
> static ThreadGroup mainThreadGroup;
>
>
> --
> Weldon Washburn
> Intel Enterprise Solutions Software Division