[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7126: fix: Fix panic in filter predicate

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7126:
URL: https://github.com/apache/arrow-datafusion/pull/7126#discussion_r1277990307


##########
datafusion/core/src/physical_plan/filter.rs:
##########
@@ -191,11 +190,8 @@ impl ExecutionPlan for FilterExec {
     fn statistics(&self) -> Statistics {
         let predicate = self.predicate();
 
-        if let Some(binary) = predicate.as_any().downcast_ref::<BinaryExpr>() {
-            let columns = collect_columns(predicate);
-            if !is_operator_supported(binary.op()) || columns.is_empty() {
-                return Statistics::default();
-            }
+        if !check_support(predicate) {

Review Comment:
   I don't know its purpose -- given that all the tests still pass I think the answer is no, but it would be good to get a second opinion on that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org