You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/29 17:11:45 UTC

[GitHub] [superset] lilykuang commented on a change in pull request #19364: feat: Embedded dashboard configuration

lilykuang commented on a change in pull request #19364:
URL: https://github.com/apache/superset/pull/19364#discussion_r837715915



##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -658,6 +672,14 @@ class Header extends React.PureComponent {
             />
           )}
 
+          {isFeatureEnabled(FeatureFlag.EMBEDDED_SUPERSET) && (

Review comment:
       should `userCanCurate` be used here instead just the feature flag check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org