You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ab...@apache.org on 2019/12/12 01:10:36 UTC
[kudu] branch master updated: [tool] KUDU-1938 Fix VARCHAR handling
in tools
This is an automated email from the ASF dual-hosted git repository.
abukor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new a8c6ea2 [tool] KUDU-1938 Fix VARCHAR handling in tools
a8c6ea2 is described below
commit a8c6ea258c06407c1a4fef260da3a1cb70529bd9
Author: Attila Bukor <ab...@apache.org>
AuthorDate: Tue Dec 10 16:47:03 2019 -0800
[tool] KUDU-1938 Fix VARCHAR handling in tools
Change-Id: Ib5475abf6dcf4af9b6357657c13f20059d2c1bc6
Reviewed-on: http://gerrit.cloudera.org:8080/14880
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
src/kudu/tools/tool_action_perf.cc | 1 +
src/kudu/tools/tool_action_table.cc | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/kudu/tools/tool_action_perf.cc b/src/kudu/tools/tool_action_perf.cc
index 5ccd814..ef8b2c1 100644
--- a/src/kudu/tools/tool_action_perf.cc
+++ b/src/kudu/tools/tool_action_perf.cc
@@ -505,6 +505,7 @@ Status GenerateRowData(Generator* gen, KuduPartialRow* row,
} else {
RETURN_NOT_OK(row->SetStringNoCopy(idx, fixed_string));
}
+ break;
default:
return Status::InvalidArgument("unknown data type");
}
diff --git a/src/kudu/tools/tool_action_table.cc b/src/kudu/tools/tool_action_table.cc
index 54a1650..c72e4ed 100644
--- a/src/kudu/tools/tool_action_table.cc
+++ b/src/kudu/tools/tool_action_table.cc
@@ -593,6 +593,7 @@ Status ConvertToKuduPartialRow(
reader.ExtractString(values[i], /*field=*/nullptr, &value),
error_msg);
RETURN_NOT_OK(range_bound_partial_row->SetVarchar(col_name, value));
+ break;
}
case KuduColumnSchema::BOOL:
case KuduColumnSchema::FLOAT: