[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #473: [ISSUE-472] Fix Flaky Test: LocalFileServerReadHandlerTest#testDataInconsistent

[GitBox <gi...@apache.org>]

advancedxy commented on code in PR #473:
URL: https://github.com/apache/incubator-uniffle/pull/473#discussion_r1068005136


##########
storage/src/test/java/org/apache/uniffle/storage/handler/impl/LocalFileServerReadHandlerTest.java:
##########
@@ -43,6 +43,8 @@
 public class LocalFileServerReadHandlerTest {
   @Test
   public void testDataInconsistent() throws Exception {
+    LocalFileHandlerTestBase.reset();

Review Comment:
   is it necessary to put it under a `beforeEach` block?
   
   `org.apache.uniffle.storage.handler.impl.LocalFileHandlerTest` also uses LocalFileHandlerTestBase, is it necessary to modify that class too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org