You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by de...@apache.org on 2007/09/25 15:26:06 UTC

svn commit: r579238 - /webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/InvokerWorker.java

Author: deepal
Date: Tue Sep 25 06:26:06 2007
New Revision: 579238

URL: http://svn.apache.org/viewvc?rev=579238&view=rev
Log:
seems like we are not handling Duplicate messages correctly and if some thing went wrong in the CallBackReciever then we try to send a fult to the server. but we do not have transport information to send the message. So we just drop the message 

Modified:
    webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/InvokerWorker.java

Modified: webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/InvokerWorker.java
URL: http://svn.apache.org/viewvc/webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/InvokerWorker.java?rev=579238&r1=579237&r2=579238&view=diff
==============================================================================
--- webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/InvokerWorker.java (original)
+++ webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/InvokerWorker.java Tue Sep 25 06:26:06 2007
@@ -213,13 +213,26 @@
 				AxisFault fault = new AxisFault ("Sandesha2 got a fault when doing the invocation", faultContext);
 				if (requestResponseTransport!=null)
 					requestResponseTransport.signalFaultReady(fault);
-				else
-					AxisEngine.sendFault(faultContext);
-				
-			} else	
-				AxisEngine.sendFault(faultContext);
-			
-		} catch (AxisFault e1) {
+				else {
+                    if ((faultContext.getTransportOut() != null) ||
+                            (faultContext.getProperty(MessageContext.TRANSPORT_OUT) != null)) {
+                        AxisEngine.sendFault(faultContext);
+                    } else {
+                        log.warn("Both the TO and MessageContext.TRANSPORT_OUT property are null," +
+                                " so nowhere to send the fault");
+                    }
+                }
+
+            } else	{
+                if ((faultContext.getTransportOut() != null) ||
+                        (faultContext.getProperty(MessageContext.TRANSPORT_OUT) != null)) {
+                    AxisEngine.sendFault(faultContext);
+                } else {
+                    log.warn("Both the TO and MessageContext.TRANSPORT_OUT property are null," +
+                            " so nowhere to send the fault");
+                }
+            }
+        } catch (AxisFault e1) {
 			if (log.isErrorEnabled())
 				log.error("Unable to send fault message ", e1);
 		}



---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org