You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Cliff Jansen <cl...@gmail.com> on 2013/01/24 09:14:33 UTC

Re: Review Request: Patch to allow proton to compile in C++

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8223/
-----------------------------------------------------------

(Updated Jan. 24, 2013, 8:14 a.m.)


Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming.


Changes
-------

Same, but updated to reflect changes on trunk.


Description
-------

See PROTON-159.  Note: this edited patch will not compile and run.  See the JIRA for the full patch and important background notes.


This addresses bug PROTON-159.
    https://issues.apache.org/jira/browse/PROTON-159


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.h 1435762 

Diff: https://reviews.apache.org/r/8223/diff/


Testing
-------

RHEL 6.3 (64 bit) gcc and g++ each in Release and Debug cmake builds.  proton-test, send/recv.


Thanks,

Cliff Jansen


Re: Review Request: Patch to allow proton to compile in C++

Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8223/#review15766
-----------------------------------------------------------

Ship it!


Ship It!

- Rafael Schloming


On Jan. 24, 2013, 8:14 a.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8223/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 8:14 a.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming.
> 
> 
> Description
> -------
> 
> See PROTON-159.  Note: this edited patch will not compile and run.  See the JIRA for the full patch and important background notes.
> 
> 
> This addresses bug PROTON-159.
>     https://issues.apache.org/jira/browse/PROTON-159
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.h 1435762 
> 
> Diff: https://reviews.apache.org/r/8223/diff/
> 
> 
> Testing
> -------
> 
> RHEL 6.3 (64 bit) gcc and g++ each in Release and Debug cmake builds.  proton-test, send/recv.
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Re: Review Request: Patch to allow proton to compile in C++

Posted by Mary Hinton <m....@nc.rr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8223/#review15661
-----------------------------------------------------------

Ship it!


Ship It!

- Mary Hinton


On Jan. 24, 2013, 8:14 a.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8223/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 8:14 a.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming.
> 
> 
> Description
> -------
> 
> See PROTON-159.  Note: this edited patch will not compile and run.  See the JIRA for the full patch and important background notes.
> 
> 
> This addresses bug PROTON-159.
>     https://issues.apache.org/jira/browse/PROTON-159
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.h 1435762 
> 
> Diff: https://reviews.apache.org/r/8223/diff/
> 
> 
> Testing
> -------
> 
> RHEL 6.3 (64 bit) gcc and g++ each in Release and Debug cmake builds.  proton-test, send/recv.
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Re: Review Request: Patch to allow proton to compile in C++

Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8223/#review15768
-----------------------------------------------------------

Ship it!


Ship It!

- Kenneth Giusti


On Jan. 24, 2013, 8:14 a.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8223/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 8:14 a.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming.
> 
> 
> Description
> -------
> 
> See PROTON-159.  Note: this edited patch will not compile and run.  See the JIRA for the full patch and important background notes.
> 
> 
> This addresses bug PROTON-159.
>     https://issues.apache.org/jira/browse/PROTON-159
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.h 1435762 
> 
> Diff: https://reviews.apache.org/r/8223/diff/
> 
> 
> Testing
> -------
> 
> RHEL 6.3 (64 bit) gcc and g++ each in Release and Debug cmake builds.  proton-test, send/recv.
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>