You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2022/04/13 11:52:46 UTC
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18412
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
After building Impala with buildall.sh using the -debug_noopt option,
the Impala cluster cannot be started:
./buildall.sh -debug_noopt
[...]
bin/start-impala-cluster.py
Traceback (most recent call last):
File "bin/start-impala-cluster.py", line 166, in <module>
KUDU_RPC_TIMEOUT = build_flavor_timeout(0, slow_build_timeout=60000)
File "/home/user/Impala/tests/common/environ.py", line 416, in
build_flavor_timeout
cluster_properties = ImpalaTestClusterProperties.get_instance()
File "/home/user/Impala/tests/common/environ.py", line 254, in
get_instance
ImpalaTestClusterFlagsDetector.detect_using_build_root_or_web_ui(IMPALA_HOME)
File "/home/user/Impala/tests/common/environ.py", line 175, in
detect_using_build_root_or_web_ui
ImpalaTestClusterFlagsDetector.validate_build_flags(build_type,
library_link_type)
File "/home/user/Impala/tests/common/environ.py", line 196, in
validate_build_flags
raise Exception("Unknown build type {0}".format(build_type))
Exception: Unknown build type debug_noopt
Adding a new 'DEBUG_NOOPT' entry to 'VALID_BUILD_TYPES' in
tests/common/environ.py solves the issue.
Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
---
M tests/common/environ.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/18412/1
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8047/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 11:32:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 11:32:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
IMPALA-11110 added the 'debug_noopt' build option but after building
Impala with it, starting the Impala cluster fails:
[...]
File "/home/user/Impala/tests/common/environ.py", line 196, in
validate_build_flags
raise Exception("Unknown build type {0}".format(build_type))
Exception: Unknown build type debug_noopt
Adding a new 'DEBUG_NOOPT' entry to 'VALID_BUILD_TYPES' in
tests/common/environ.py solves the issue.
Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
---
M buildall.sh
M tests/common/environ.py
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/18412/2
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
IMPALA-11110 added the 'debug_noopt' build option but after building
Impala with it, starting the Impala cluster fails:
[...]
File "/home/user/Impala/tests/common/environ.py", line 196, in
validate_build_flags
raise Exception("Unknown build type {0}".format(build_type))
Exception: Unknown build type debug_noopt
Adding a new 'DEBUG_NOOPT' entry to 'VALID_BUILD_TYPES' in
tests/common/environ.py solves the issue.
Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Reviewed-on: http://gerrit.cloudera.org:8080/18412
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M buildall.sh
M tests/common/environ.py
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 15:12:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 16:00:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 1:
(1 comment)
Change itself looks good to me, thanks for spotting this!
A couple of minor suggestions (no really strong feelings here):
- I'd suggest adding a comment to buildall.sh (if you can find a suitably central place there) to remind anyone changing the build options to keep environ.py in synch
- For the commit message I'd suggest referring to the original change, IMPALA-11110 that added debug_noopt in the first place. This is more for historical reference for future readers/reviewers, or maybe downstream users.
Leaving just a +1 for now to give Joe chance to look at it.
http://gerrit.cloudera.org:8080/#/c/18412/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18412/1//COMMIT_MSG@12
PS1, Line 12: ./buildall.sh -debug_noopt
Nit: as you have filed a dedicated Jira ticket for this failure complete with the error backtrace, repeating the same backtrace in the commit message seems somewhat redundant. I'd suggest maybe just keeping the last line (the relevant exception/location) here; details can always be looked up in the Jira ticket.
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 12:24:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10439/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 12:12:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 )
Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
Gerrit-Change-Number: 18412
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 13:31:31 +0000
Gerrit-HasComments: No