[GitHub] [incubator-superset] villebro commented on a change in pull request #8181: [bugfix] Correctly quote table and schema in select_star

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8181: [bugfix] Correctly quote table and schema in select_star
URL: https://github.com/apache/incubator-superset/pull/8181#discussion_r321416682
 
 

 ##########
 File path: tests/model_tests.py
 ##########
 @@ -126,6 +126,28 @@ def test_select_star(self):
         )
         assert sql.startswith(expected)
 
+    def test_select_star_with_exotic_names(self):
+        main_db = get_example_database()
 
 Review comment:
   It's my understanding that the example db falls back to `SQLALCHEMY_DATABASE_URI` if `SQLALCHEMY_EXAMPLES_URI` is undefined, i.e. it should test all engines that have a tox env.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org