[GitHub] [skywalking] wu-sheng commented on a change in pull request #4758: Format index name with namespace

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4758:
URL: https://github.com/apache/skywalking/pull/4758#discussion_r422052301



##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/HistoryDeleteEsDAO.java
##########
@@ -66,7 +66,7 @@ public void deleteHistory(Model model, String timeBucketColumnName, int ttl) thr
         for (String prepareDeleteIndex : prepareDeleteIndexes) {
             client.deleteByIndexName(prepareDeleteIndex);
         }
-        String latestIndex = TimeSeriesUtils.latestWriteIndexName(model);
+        String latestIndex = client.formatIndexName(TimeSeriesUtils.latestWriteIndexName(model));
         if (!leftIndices.contains(latestIndex)) {
             client.createIndex(latestIndex);
         }

Review comment:
       `latestIndex` variable should be used in `contains` check only, `createIndex` should use the unformatted name like the old codes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org