[GitHub] [flink] zhuzhurk commented on a diff in pull request #21840: [FLINK-29481] Show jobType in webUI

["zhuzhurk (via GitHub)" <gi...@apache.org>]

zhuzhurk commented on code in PR #21840:
URL: https://github.com/apache/flink/pull/21840#discussion_r1138368567


##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -123,7 +123,15 @@ public class ExecutionConfig implements Serializable, Archiveable<ArchivedExecut
             key("hidden.execution.mode")
                     .enumType(ExecutionMode.class)
                     .defaultValue(ExecutionMode.PIPELINED)
-                    .withDescription("Defines how data exchange happens - batch or pipelined");
+                    .withDescription(
+                            "Defines how data exchange happens "
+                                    + "- batch or pipelined(used in the deprecated DataSet API)");
+
+    private static final ConfigOption<String> JOB_TYPE =

Review Comment:
   `jobType` is an automatically derived property instead of a user setting. Therefore, I would not put it in `ExecutionConfig`.
   To achieve the goal to show jobType on the web UI, we can introduce a `jobType` to `JobConfigInfo` and `AccessExecutionGraph`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org