[jira] [Commented] (FLINK-9473) Compilation fails after upgrade to Calcite 1.17

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558100#comment-16558100 ] 

ASF GitHub Bot commented on FLINK-9473:
---------------------------------------

snuyanzin commented on issue #6099: [FLINK-9473][Table API & SQL] Added new methods into ExternalCatalogSchema based on interface Schema changes in Calcite
URL: https://github.com/apache/flink/pull/6099#issuecomment-408037577
 
 
   thank you for your comment I will close  this PR as Calcite 1.17.0 released and I found more things to be fixed especially relating to the test. As soon as I finished I will create a new PR with mentioning of Calcite's tickets because of which some changes in  Flink's code are required

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Compilation fails after upgrade to Calcite 1.17
> -----------------------------------------------
>
>                 Key: FLINK-9473
>                 URL: https://issues.apache.org/jira/browse/FLINK-9473
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>
> {noformat}
> /apacheFlink/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala:40: error: class ExternalCatalogSchema needs to be abstract, since:
> [ERROR] it has 2 unimplemented members.
> [ERROR] /** As seen from class ExternalCatalogSchema, the missing signatures are as follows.
> [ERROR]  *  For convenience, these are usable as stub implementations.
> [ERROR]  */
> [ERROR]   def getType(x$1: String): org.apache.calcite.rel.type.RelProtoDataType = ???
> [ERROR]   def getTypeNames(): java.util.Set[String] = ???
> [ERROR] 
> [ERROR] class ExternalCatalogSchema(
> [ERROR]       ^
> [WARNING] two warnings found
> [ERROR] one error found
> {noformat}
> while https://issues.apache.org/jira/browse/CALCITE-2045 into interface _org.apache.calcite.schema.Schema_ there were introduced two more methods: _org.apache.calcite.schema.Schema#getTypeNames_, _org.apache.calcite.schema.Schema#getType_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)