You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/06 15:21:41 UTC

[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #419: Remove DictionaryArray::keys_array method

jhorstmann commented on a change in pull request #419:
URL: https://github.com/apache/arrow-rs/pull/419#discussion_r646147652



##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -1450,7 +1451,8 @@ where
         cast_with_options(&dict_array.values(), to_type, cast_options)?;
 
     // Note take requires first casting the indices to u32
-    let keys_array: ArrayRef = Arc::new(dict_array.keys_array());
+    let keys_array: ArrayRef =

Review comment:
       If primitive arrays were cloneable this would just be `Arc::new(dict_array.keys().clone())`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org