[GitHub] [beam] TheNeuralBit commented on a change in pull request #15587: [BEAM-12907] Run DataFrame API tests with multiple pandas versions

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #15587:
URL: https://github.com/apache/beam/pull/15587#discussion_r728255925



##########
File path: sdks/python/tox.ini
##########
@@ -249,3 +249,14 @@ commands =
   /bin/sh -c "pip freeze | grep -E '(pyarrow|numpy)'"
   # TODO(BEAM-12985): Running run_pytest.sh with -m causes us to run all the tests twice
   {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '-m uses_pyarrow'
+
+[testenv:py{36,37,38}-pandas-{11,12,13}]
+deps =
+  11: pandas>=1.1.0,<1.2.0
+  12: pandas>=1.2.0,<1.3.0
+  13: pandas>=1.3.0,<1.4.0
+commands =
+  # Log pandas and numpy version for debugging
+  /bin/sh -c "pip freeze | grep -E '(pandas|numpy)'"
+  # Run all DataFrame API unit tests
+  {toxinidir}/scripts/run_pytest.sh {envname} 'apache_beam/dataframe'

Review comment:
       Thanks, good question. We don't in this case since we're not using `-m` to select tests. #15693 also added a check to make run_pytest.sh fail fast in the case we hit there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org