You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/04 15:16:01 UTC

[jira] [Commented] (GEODE-4799) Remove static member variables from Apache.Geode.Client.Serializable

    [ https://issues.apache.org/jira/browse/GEODE-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425687#comment-16425687 ] 

ASF subversion and git services commented on GEODE-4799:
--------------------------------------------------------

Commit fc9c81c24c0d07bfeabd69d9a3bc436058179695 in geode-native's branch refs/heads/develop from [~eburghardt]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=fc9c81c ]

Geode 4799: Removing static members from Serializable 

* Cleanup warnings

* Replace GetPdxSerializer

* PDXSerializerRegistry passes test

* PdxTypeMapper moved to TypeRegistry

* Moved PDX to LocalType maps to TypeRegistry.

* Move GetType to TypeRegistry
  Signed-off-by: Ernie Burghardt <eb...@pivotal.io>

* Put back reference assembly recursive search
  Signed-off-by: Michael Oleske <mo...@pivotal.io>

*  Add new project for multiple cache testing

* Attempt at test, but server fails to start

*  multi cache test running
   Signed-off-by: Jacob Barrett <jb...@pivotal.io>

* move RegisterPdxType to TypeRegistry
  Signed-off-by: Michael Oleske <mo...@pivotal.io>

* Temporary commit to get stuff in the shared repo

* Added a new MultiCache test and
- rolled back to a compilable state

* Made ManagedDelegatesGeneric instance based
- added test for RegisterPdxType

* Remove static from:
- NativeDelegatesGeneric
- DelegateMapGeneric
- BuiltInDelegatesGeneric

* Keeps ManagedTypeToTypeId static.

* Removed static from RegisterTypeGeneric

* Removed cache param from RegisterTypeGeneric since no longer needed

* Removed static from UnregisterTypeGeneric

* Add TypeRegistry files to MakeLists and fixed typo in file name

* Split the integration and unit tests in clicache multcache tests.

* Fixing Travis CI build.

* Remove unneeded files from unittests

* Rename test projects and remove GEODE_ROOT from top cmake file

* Undo .travis.yml change

* Rename to remove MultipleCache prefix

* Remove MultipleCache prefix and
- make test project name configurable and rename test class
- remove Serializable::Clear()
- moved statics used for object creation to TypeRegistry

* GEODE-4799: Fixing compilation issue due to namespacing
  Signed-off-by: Mike Martell <mm...@pivotal.io>

* GEODE-4799: Removing generated file from source control
  Signed-off-by: Mike Martell <mm...@pivotal.io>

* GEODE-4799: First set of PR feedback changes
  Signed-off-by: Ryan McMahon <rm...@pivotal.io>

* Changes:
- test rename
- moved configurable bits to a separate file

* Added packages.config to project and add newline at the end of some files.

* Remove commented out code

* GEODE-4799: Adding missing GeodeServer.cs file

* GEODE-4799: GeodeServer.cs was in wrong location
  Signed-off-by: Mike Martell <mm...@pivotal.io>

* GEODE-4799: Fix to use proper relative nuget packages

* Removed bad ignore line


> Remove static member variables from Apache.Geode.Client.Serializable
> --------------------------------------------------------------------
>
>                 Key: GEODE-4799
>                 URL: https://issues.apache.org/jira/browse/GEODE-4799
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently this class contains a bunch of static member variables. These need to be converted to instance variables.
> This change will allow each cache instance to have its own custom serializer without needing to use a chained serializer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)