You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Íñigo Goiri (Jira)" <ji...@apache.org> on 2019/09/20 18:37:00 UTC
[jira] [Commented] (HDFS-14860) Clean Up
StoragePolicySatisfyManager.java
[ https://issues.apache.org/jira/browse/HDFS-14860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934664#comment-16934664 ]
Íñigo Goiri commented on HDFS-14860:
------------------------------------
The synchronization change makes sense.
Just a minor comment on line 142, right now we are doing a concatenation while before the if guarded it.
Anyway we can shorten the text?
> Clean Up StoragePolicySatisfyManager.java
> -----------------------------------------
>
> Key: HDFS-14860
> URL: https://issues.apache.org/jira/browse/HDFS-14860
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HDFS-14860.1.patch
>
>
> * Remove superfluous debug log guards
> * Use {{java.util.concurrent}} package for internal structure instead of external synchronization.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org