You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2022/02/22 07:43:31 UTC

[GitHub] [tez] abstractdog commented on a change in pull request #189: TEZ-4388: Asynchttpclient can cause stuck TezChild processes

abstractdog commented on a change in pull request #189:
URL: https://github.com/apache/tez/pull/189#discussion_r811653577



##########
File path: tez-runtime-library/src/main/java/org/apache/tez/http/async/netty/AsyncHttpConnection.java
##########
@@ -102,6 +103,15 @@ private void initClient(HttpConnectionParams httpConnParams) throws IOException
               .build();
           DefaultAsyncHttpClientConfig config = builder.build();
           httpAsyncClient = new DefaultAsyncHttpClient(config);
+          TezRuntimeShutdownHandler.addShutdownTask(new Thread(() -> {
+            try {
+              if (httpAsyncClient != null) {
+                httpAsyncClient.close();

Review comment:
       thanks @rbalamohan, makes sense, fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org