[GitHub] spark pull request #17031: [SPARK-19702][MESOS] Add suppress/revive support ...

[skonto <gi...@git.apache.org>]

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17031#discussion_r103261951
  
    --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala ---
    @@ -48,45 +48,50 @@ class MesosClusterSchedulerSuite extends SparkFunSuite with LocalSparkContext wi
         }
     
         driver = mock[SchedulerDriver]
    -    scheduler = new MesosClusterScheduler(
    -      new BlackHoleMesosClusterPersistenceEngineFactory, conf) {
    -      override def start(): Unit = { ready = true }
    +    val persistenceFactory = new BlackHoleMesosClusterPersistenceEngineFactory()
    +    scheduler = new MesosClusterScheduler(persistenceFactory, conf) {
    +      override def start(): Unit = { this.ready = true }
         }
         scheduler.start()
    +    scheduler.registered(driver, Utils.TEST_FRAMEWORK_ID, Utils.TEST_MASTER_INFO)
    +
    +    verify(driver, times(1)).suppressOffers()
    --- End diff --
    
    Here this call has no result right, no suppress.We add the driver and then at the end this called is made, so the queue is not empty, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org