You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by davebshow <gi...@git.apache.org> on 2016/06/17 21:05:19 UTC
[GitHub] tinkerpop pull request #343: restructured gremlin-python package
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/343
restructured gremlin-python package
This PR restructures the Gremlin-Python package to unify packages, modules, and classes under the gremlin_python namespace as discussed on the mailing list. It also provides a minor fix to ensure Python 2/3 compatibility, as well as relative imports for convenience and flexibility.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davebshow/tinkerpop restructure_gremlin_python
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit db111729952c28ccee82d5b9e3aa627b68f2e928
Author: davebshow <da...@gmail.com>
Date: 2016-06-17T20:56:56Z
restructured gremlin-python package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/343
Thanks @davebshow - things are still moving around a little bit. @okram do you agree that dave should hold off for a little bit until we stabilize a bit further? perhaps a week or so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/343
Yea -- its a little crazy on that branch right now. It will stabilize (be near the end) by the end of next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/343
Sorry, I hurried this because I was leaving town and have not had much access to the internet. Due to the many conflicts it will be simpler to close and create a new PR. I will make sure all tests pass before submitting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/343
When I run the test suite, I get failures.
```
File "src/main/jython/gremlin_python/groovy_translator.py", line 23, in <module>
from .gremlin_python import P
ValueError: Attempted relative import in non-package
```
Easy solution I can do or would you like to fix up your PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #343: restructured gremlin-python package
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow closed the pull request at:
https://github.com/apache/tinkerpop/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/343
This just changed to here:
https://github.com/apache/tinkerpop/blob/TINKERPOP-1278/gremlin-variant/src/test/java/org/apache/tinkerpop/gremlin/python/JythonScriptEngineSetup.java#L36-L59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/343
This is how the Python modules are loaded into Jython.
https://github.com/apache/tinkerpop/blob/TINKERPOP-1278/gremlin-variant/src/test/java/org/apache/tinkerpop/gremlin/python/PythonProvider.java#L39-L62
Recommendations to make it more "package like" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #343: restructured gremlin-python package
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/343
This would probably be because the way tests are set up the modules are getting executed as a script instead of as a package. I don't know how to fix this off the top of my head--I haven't familiarized myself with how tests are being run, and I unfortunately don't have time to figure it out right now. Ideally, Gremlin-Python would be installed using pip and used normally as a package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---