You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/02/12 08:34:08 UTC
[jira] Created: (JCR-1374) [PATCH] make sure streams are closed
[PATCH] make sure streams are closed
------------------------------------
Key: JCR-1374
URL: https://issues.apache.org/jira/browse/JCR-1374
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-core
Affects Versions: 1.4
Reporter: Dave Brosius
Fix For: 1.4.1
Attachments: close_on_finally.patch
Stream isn't closed on end of use. this patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1374) [PATCH] make sure streams are closed
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568016#action_12568016 ]
Thomas Mueller commented on JCR-1374:
-------------------------------------
Of course you are right, the input stream should be closed. Did you experience a problem if it is not? Or it the patch just because it _should_ be closed? In any case it will be fixed, but not sure if it makes sense to fix in 1.4.1.
To Tobias: Jackrabbit doesn't have a dependency to IOUtils, is it OK if I add it to the pom.xml and to http://jackrabbit.apache.org/doc/firststeps.html (list of dependencies)?
> [PATCH] make sure streams are closed
> ------------------------------------
>
> Key: JCR-1374
> URL: https://issues.apache.org/jira/browse/JCR-1374
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4
> Reporter: Dave Brosius
> Fix For: 1.4.1
>
> Attachments: close_on_finally.patch
>
>
> Stream isn't closed on end of use. this patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1374) [PATCH] make sure streams are closed
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller resolved JCR-1374.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.4.1)
1.5
Assignee: Thomas Mueller
Committed in revision 620783.
To avoid adding a new class or dependency, now just close() is called.
> [PATCH] make sure streams are closed
> ------------------------------------
>
> Key: JCR-1374
> URL: https://issues.apache.org/jira/browse/JCR-1374
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4
> Reporter: Dave Brosius
> Assignee: Thomas Mueller
> Fix For: 1.5
>
> Attachments: close_on_finally.patch
>
>
> Stream isn't closed on end of use. this patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1374) [PATCH] make sure streams are closed
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated JCR-1374:
------------------------------
Attachment: close_on_finally.patch
> [PATCH] make sure streams are closed
> ------------------------------------
>
> Key: JCR-1374
> URL: https://issues.apache.org/jira/browse/JCR-1374
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4
> Reporter: Dave Brosius
> Fix For: 1.4.1
>
> Attachments: close_on_finally.patch
>
>
> Stream isn't closed on end of use. this patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1374) [PATCH] DbDataStore: Make sure streams
are closed
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1374:
-------------------------------
Priority: Minor (was: Major)
Fix Version/s: (was: 1.5)
1.4.1
Issue Type: Bug (was: Improvement)
Summary: [PATCH] DbDataStore: Make sure streams are closed (was: [PATCH] make sure streams are closed)
I moved the InputStream.close() call to a finally block in revision 628263. I also removed the extra BufferdInputStream wrapper as Properties.load() already buffers the input.
I classified this as a minor bug as all streams should be properly closed. Merged to the 1.4 branch in revision 628266.
> [PATCH] DbDataStore: Make sure streams are closed
> -------------------------------------------------
>
> Key: JCR-1374
> URL: https://issues.apache.org/jira/browse/JCR-1374
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 1.4
> Reporter: Dave Brosius
> Assignee: Thomas Mueller
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: close_on_finally.patch
>
>
> Stream isn't closed on end of use. this patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1374) [PATCH] make sure streams are closed
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568008#action_12568008 ]
Tobias Bocanegra commented on JCR-1374:
---------------------------------------
i would use:
http://commons.apache.org/io/api-release/org/apache/commons/io/IOUtils.html#closeQuietly(java.io.InputStream)
> [PATCH] make sure streams are closed
> ------------------------------------
>
> Key: JCR-1374
> URL: https://issues.apache.org/jira/browse/JCR-1374
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4
> Reporter: Dave Brosius
> Fix For: 1.4.1
>
> Attachments: close_on_finally.patch
>
>
> Stream isn't closed on end of use. this patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.