[jira] [Commented] (ZOOKEEPER-1195) SASL authorizedID being incorrectly set: should use getHostName() rather than getServiceName()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108808#comment-13108808 ] 

Hadoop QA commented on ZOOKEEPER-1195:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12495235/ZOOKEEPER-1195.patch
  against trunk revision 1172406.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/569//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/569//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/569//console

This message is automatically generated.

> SASL authorizedID being incorrectly set: should use getHostName() rather than getServiceName()
> ----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1195
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1195
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Eugene Koontz
>            Assignee: Eugene Koontz
>         Attachments: ZOOKEEPER-1195.patch
>
>
> Tom Klonikowski writes:
>     Hello developers,
>     the SaslServerCallbackHandler in trunk changes the principal name
>     service/host@REALM to service/service@REALM (i guess unintentionally).
>     lines 131-133:
>     if (!removeHost() && (kerberosName.getHostName() != null)) {
>       userName += "/" + kerberosName.getServiceName();
>     }
>     Server Log:
>     SaslServerCallbackHandler@115] - Successfully authenticated client:
>     authenticationID=fetcher/ubook@QUINZOO;
>     authorizationID=fetcher/ubook@QUINZOO.
>     SaslServerCallbackHandler@137] - Setting authorizedID:
>     fetcher/fetcher@QUINZOO

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira