You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/05 14:43:17 UTC
[GitHub] [flink] wangxlong opened a new pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
wangxlong opened a new pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769
## What is the purpose of the change
Override explainSource method for JDBCTableSource.
## Brief change log
Add explainSource for JDBCTableSource.
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial work without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
- The S3 file system connector: ( no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570976844
@wangxlong could you add a test for jdbc project push down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-571039643
> Hi @wangxlong , What I mean:
>
> 1. If we fix it in `JDBCTableSource`, it should be in 1.10 and 1.9.
> 2. If we fix it in `TableSource`, it should be in 1.11.
>
> Option 1 and Option 2 can be two things to finish. (We can do option 1 in 1.10 and 1.9, do option 2 in master)
@JingsongLi I am sorry. It is my misunderstanding. I have added a test.
BTW, Should I open a JIRA to discuss option2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r364185518
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactoryTest.java
##########
@@ -182,6 +184,12 @@ public void testJDBCWithFilter() {
assertEquals(projectedFields.get("aaa"), DataTypes.INT());
assertNull(projectedFields.get("bbb"));
assertEquals(projectedFields.get("ccc"), DataTypes.DOUBLE());
+
+ // test jdbc table source description
+ List<String> fieldNames = ((RowType) actual.getProducedDataType().getLogicalType()).getFieldNames();
+ String expectedSourceDescription = actual.getClass().getSimpleName()
+ + "(" + String.join(", ", fieldNames.stream().toArray(String[]::new)) + ")";
Review comment:
I think we should add an integreation test to verify the JDBC source can work when project is pushed down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144346915 TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4337 TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
* 7d5e177e31e0509178ac60e795178b529d04a273 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144346915) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4337)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
* 7d5e177e31e0509178ac60e795178b529d04a273 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r366370879
##########
File path: flink-connectors/flink-jdbc/pom.xml
##########
@@ -54,6 +54,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
Yes, It is ok to set scope as `test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-571025175
Thank you for your advice@wuchong @godfreyhe @JingsongLi . It is my duty to add a jdbc project push down test to verify. I am ok to fix it in 1.11.
From my side, there are two aspects need to be discussed:
1、How to fix it. I agree with @godfreyhe, we should fix the default implementation of explainSource in TableSource, just like follow:
` List<String> fieldNames = ((RowType) getProducedDataType().getLogicalType()).getFieldNames();
return TableConnectorUtils.generateRuntimeName(
getClass(),
fieldNames.stream().toArray(String[]::new));`
2、How to add a test to verify it.
I found there is a test to verify jdbc push down in JDBCTableSourceSinkFactoryTest#testJDBCWithFilter. I think the name of method maybe not good. We can change it to testJDBCFieldsProjection. On the basis of this test, we can add some code to verify source description just like follow:
` List<String> fieldNames = ((RowType) actual.getProducedDataType().getLogicalType()).getFieldNames();
String expectedSourceDescription = actual.getClass().getSimpleName()
+ "(" + String.join(", ", fieldNames.stream().toArray(String[]::new)) + ")";
assertEquals(expectedSourceDescription ,actual.explainSource());`
Thank you all, I also comment in the relative jira. Looking forward to your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-575178223
ping @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r366136972
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.java.io.jdbc;
+
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.java.StreamTableEnvironment;
+import org.apache.flink.table.runtime.utils.StreamITCase;
+import org.apache.flink.types.Row;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * IT case for {@link JDBCTableSource}.
+ */
+
Review comment:
remove empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r366371055
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.java.io.jdbc;
+
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.java.StreamTableEnvironment;
+import org.apache.flink.table.runtime.utils.StreamITCase;
+import org.apache.flink.types.Row;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * IT case for {@link JDBCTableSource}.
+ */
+public class JDBCTableSourceITCase extends JDBCTestBase {
+
+ private static final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+ private static final EnvironmentSettings bsSettings = EnvironmentSettings.newInstance().useBlinkPlanner().inStreamingMode().build();
+ private static final StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, bsSettings);
+
+ static final String TABLE_SOURCE_SQL = "CREATE TABLE books (" +
+ " id int, " +
+ " title varchar, " +
+ " author varchar, " +
+ " price double, " +
+ " qty int " +
+ ") with (" +
+ " 'connector.type' = 'jdbc', " +
+ " 'connector.url' = 'jdbc:derby:memory:ebookshop', " +
+ " 'connector.table' = 'books', " +
+ " 'connector.driver' = 'org.apache.derby.jdbc.EmbeddedDriver' " +
+ ")";
+
+ static {
Review comment:
Thanks, Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r366370879
##########
File path: flink-connectors/flink-jdbc/pom.xml
##########
@@ -54,6 +54,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
Yes, It is ok to set scope as `test`. But I don't know why set provide in old planner before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-571026521
Hi @wangxlong , What I mean:
1. If we fix it in `JDBCTableSource`, it should be in 1.10 and 1.9.
2. If we fix it in `TableSource`, it should be in 1.11.
Option 1 and Option 2 can be two things to finish. (We can do option 1 in 1.10 and 1.9, do option 2 in master)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r366329322
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.java.io.jdbc;
+
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.java.StreamTableEnvironment;
+import org.apache.flink.table.runtime.utils.StreamITCase;
+import org.apache.flink.types.Row;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * IT case for {@link JDBCTableSource}.
+ */
+public class JDBCTableSourceITCase extends JDBCTestBase {
+
+ private static final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+ private static final EnvironmentSettings bsSettings = EnvironmentSettings.newInstance().useBlinkPlanner().inStreamingMode().build();
+ private static final StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, bsSettings);
+
+ static final String TABLE_SOURCE_SQL = "CREATE TABLE books (" +
+ " id int, " +
+ " title varchar, " +
+ " author varchar, " +
+ " price double, " +
+ " qty int " +
+ ") with (" +
+ " 'connector.type' = 'jdbc', " +
+ " 'connector.url' = 'jdbc:derby:memory:ebookshop', " +
+ " 'connector.table' = 'books', " +
+ " 'connector.driver' = 'org.apache.derby.jdbc.EmbeddedDriver' " +
+ ")";
+
+ static {
Review comment:
Please use `@BeforeClass` instead of static code block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-573978365
ping @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r366329915
##########
File path: flink-connectors/flink-jdbc/pom.xml
##########
@@ -54,6 +54,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
Can we set the scope only for `test`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144346915 TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4337 TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
* 7d5e177e31e0509178ac60e795178b529d04a273 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144346915) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4337)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-571973022
@wangxlong Yes, you can.
LGTM +1
CC: @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570979120
I think we should fix the default implementation of `explainSource` in `TableSource` which returns the field names from `getProducedDataType` instead of `getTableSchema`. Table schema is a logical description of a table and should not be part of the physical TableSource, while the value of `explainSource` should be changed with optimization (e.g. projection push down)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-571039643
> Hi @wangxlong , What I mean:
>
> 1. If we fix it in `JDBCTableSource`, it should be in 1.10 and 1.9.
> 2. If we fix it in `TableSource`, it should be in 1.11.
>
> Option 1 and Option 2 can be two things to finish. (We can do option 1 in 1.10 and 1.9, do option 2 in master)
@JingsongLi I am sorry. It is my misunderstanding. I have added a test.
Should I close this, and then open two pull request against release-1.9 and release-1.10? Or we can also do option1 on master, This maybe not conflict with option2?
BTW, Should I open a JIRA to discuss option2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570918729
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 (Sun Jan 05 14:45:13 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15479).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on a change in pull request #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#discussion_r364536728
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactoryTest.java
##########
@@ -182,6 +184,12 @@ public void testJDBCWithFilter() {
assertEquals(projectedFields.get("aaa"), DataTypes.INT());
assertNull(projectedFields.get("bbb"));
assertEquals(projectedFields.get("ccc"), DataTypes.DOUBLE());
+
+ // test jdbc table source description
+ List<String> fieldNames = ((RowType) actual.getProducedDataType().getLogicalType()).getFieldNames();
+ String expectedSourceDescription = actual.getClass().getSimpleName()
+ + "(" + String.join(", ", fieldNames.stream().toArray(String[]::new)) + ")";
Review comment:
@wuchong Good idea. I have updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10769: [FLINK-15479]Override
explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-574090782
Thanks @wuchong, I have updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144315679 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331 TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144346915 TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
Hash:7d5e177e31e0509178ac60e795178b529d04a273 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4337 TriggerType:PUSH TriggerID:7d5e177e31e0509178ac60e795178b529d04a273
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144315679) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4331)
* 7d5e177e31e0509178ac60e795178b529d04a273 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144346915) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4337)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:4e1d0a854d224d253d452ef4188ad4ff65045b39 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4e1d0a854d224d253d452ef4188ad4ff65045b39
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
* 4e1d0a854d224d253d452ef4188ad4ff65045b39 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10769:
[FLINK-15479]Override explainSource method for JDBCTableSource
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-570920622
<!--
Meta data
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143145102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102 TriggerType:PUSH TriggerID:7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143206888 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:78085a61e23ddd68f8546fb73ce6f639d98f6e42 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115 TriggerType:PUSH TriggerID:78085a61e23ddd68f8546fb73ce6f639d98f6e42
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232268 TriggerType:PUSH TriggerID:9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143665397 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202 TriggerType:PUSH TriggerID:ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144299140 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
Hash:86a1280f8f7bda8de006c3da514dbf28a18818d4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324 TriggerType:PUSH TriggerID:86a1280f8f7bda8de006c3da514dbf28a18818d4
-->
## CI report:
* 7fe9e7e4e4b53f839656fdb2b1a1079ec4de5b68 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143145102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4102)
* 78085a61e23ddd68f8546fb73ce6f639d98f6e42 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143206888) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4115)
* 9f9c59090ca6b17d95441dd5d1b4c86be6c01bbf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232268) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4127)
* ea00615b2fcd2ad6fe9a1c03f9ba334fc23e8ddf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143665397) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4202)
* 86a1280f8f7bda8de006c3da514dbf28a18818d4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144299140) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services