You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "René Cordier (Jira)" <se...@james.apache.org> on 2020/07/15 04:44:00 UTC

[jira] [Commented] (JAMES-3305) RabbitMQ EventBus deserialization error handling

    [ https://issues.apache.org/jira/browse/JAMES-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157875#comment-17157875 ] 

René Cordier commented on JAMES-3305:
-------------------------------------

[https://github.com/linagora/james-project/pull/3567] contributed to add RabbitMQ eventBus deserialization error handling

> RabbitMQ EventBus deserialization error handling
> ------------------------------------------------
>
>                 Key: JAMES-3305
>                 URL: https://issues.apache.org/jira/browse/JAMES-3305
>             Project: James Server
>          Issue Type: Bug
>            Reporter: René Cordier
>            Priority: Major
>
> h2. Why ?
> https://issues.apache.org/jira/browse/JAMES-3290 proved a non deserializable message caused the entire MailQueue processing to crash.
> [https://github.com/linagora/james-project/pull/3532] solved this by doing an explicit nack on such messages, relying on RabbitMQ dead-letter exchanges to not loose data. The message is thus effectively ignored.
> Following this, we need to further investigate RabbitMQ related code and evaluate if there is similar issues.
> A quick study proved the EventBus is subject to the same class of bugs.
> h2. Acceptance criteria
>  * If a message cannot be deserialized, following legitimate events can still be processed.
>  * Discarded messages are stored in a dead-letter queue and not lost
> Note that both group registration and key registration needs to be tested: Regarding key registration, dropping events is OK.
> h2. Definition of done
>  * Write tests to reproduce the issue and the expected behaviour
>  * Implement the fix leveraging dead-letter and nack



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org