You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/25 08:08:22 UTC
[GitHub] [airflow] parvezmkhan opened a new issue, #23910: Airflow SalesforceHook empty security token
parvezmkhan opened a new issue, #23910:
URL: https://github.com/apache/airflow/issues/23910
### Apache Airflow version
2.2.2
### What happened
When creating salesforce hook like below get
sf = SalesforceHook(salesforce_conn_id="test_sf")
Get below TypeError
You must provide login information or an instance and token
This is test salesforce domain.
User name and password are set correctly in Airflow connection but security token is not filled.
I expect the connection to setup without error
### What you think should happen instead
Changing https://github.com/apache/airflow/blob/1d53bec0618c042de5cd05801b0c1fe015e6b4f8/airflow/providers/salesforce/hooks/salesforce.py#L144
to below works, i.e. connection is established
security_token=extras["extra__salesforce__security_token"] or '',
### How to reproduce
Setup salesforce connection in airflow with
* user name, password and no security token
* domain : test
* API version : 54.0
### Operating System
macOS 11.2.3
### Versions of Apache Airflow Providers
apache-airflow-providers-salesforce 3.3.0
simple-salesforce 1.11.4
### Deployment
Virtualenv installation
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] parvezmkhan commented on issue #23910: Airflow SalesforceHook empty security token
Posted by GitBox <gi...@apache.org>.
parvezmkhan commented on issue #23910:
URL: https://github.com/apache/airflow/issues/23910#issuecomment-1138079358
@eladkal
Thanks a lot for looking into this.
I upgraded to 3.4.4 as shown below
`
pip install --upgrade apache-airflow-providers-salesforce==3.4.4
pip show apache-airflow-providers-salesforce
Name: apache-airflow-providers-salesforce
Version: 3.4.4
`
After running, still get same error
`
sf = SalesforceHook(salesforce_conn_id="test_sf")
...
TypeError: You must provide login information or an instance and token
`
Am I doing something wrong?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #23910: Airflow SalesforceHook empty security token
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #23910:
URL: https://github.com/apache/airflow/issues/23910#issuecomment-1136926334
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #23910: Airflow SalesforceHook empty security token
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #23910: Airflow SalesforceHook empty security token
URL: https://github.com/apache/airflow/issues/23910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #23910: Airflow SalesforceHook empty security token
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #23910:
URL: https://github.com/apache/airflow/issues/23910#issuecomment-1137164796
You are using `apache-airflow-providers-salesforce 3.3.0 `which is out of date.
Check the changelog version [3.4.0](https://pypi.org/project/apache-airflow-providers-salesforce/#description) included
[Do not require all extras for SalesforceHook (#19530)](https://github.com/apache/airflow/pull/19530)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #23910: Airflow SalesforceHook empty security token
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #23910:
URL: https://github.com/apache/airflow/issues/23910#issuecomment-1138082779
Please follow
https://airflow.apache.org/docs/apache-airflow-providers-salesforce/stable/connections/salesforce.html
There are different types of authentication to snowflake. Make sure you are following the insteuctions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org