You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/28 09:47:21 UTC
[GitHub] [pulsar] StevenLuMT opened a new pull request #14490: add rack metrics
StevenLuMT opened a new pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490
Master Issue: no-issue
### Motivation
- pulsar lacks the bookie rack's metric in use
### Modifications
- Add main class BookkeeperIsolationGroupsStats,two categories of metrics:
1. current rack group's rack metrics2.
all rack group's writable rack metrics
- metric main class is inited in class PulsarService
- add equals method in class RawBookieInfo
- add comments in class BookiesRackConfiguration
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API: (no)
- The schema: ( no )
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- [ ] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14490: add rack metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490#issuecomment-1086759412
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14490: add rack metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490#issuecomment-1054075344
@StevenLuMT:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] StevenLuMT commented on pull request #14490: add rack metrics
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490#issuecomment-1058744172
@Jason918 can you approval this workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a change in pull request #14490: add rack metrics
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on a change in pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490#discussion_r816425104
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/RawBookieInfo.java
##########
@@ -23,6 +23,8 @@
import lombok.NoArgsConstructor;
import lombok.ToString;
+import java.util.Objects;
Review comment:
checkstyle failed. Should reorder tht imports. Maybe like this：
```
import java.util.Objects;
import lombok.NoArgsConstructor;
import lombok.ToString;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #14490: add rack metrics
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490#discussion_r819207992
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/RawBookieInfo.java
##########
@@ -32,4 +33,19 @@
@ToString
Review comment:
How about just use `@Data`, that implies [@ToString](https://projectlombok.org/features/ToString), [@EqualsAndHashCode](https://projectlombok.org/features/EqualsAndHashCode)
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -810,6 +811,9 @@ public void start() throws PulsarServerException {
config.getClusterName(), config);
state = State.Started;
+
+ new BookkeeperIsolationGroupsStats(pulsarResources, getBookKeeperClient(), config,
Review comment:
A static method seems better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14490: add rack metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14490:
URL: https://github.com/apache/pulsar/pull/14490#issuecomment-1054074100
@StevenLuMT:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org