You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hsaputra <gi...@git.apache.org> on 2015/03/13 00:21:42 UTC
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/482
Remove -j and -a parameters which seemed no longer valid in the doc example for YARN
From:
./bin/flink run -j ./examples/flink-java-examples-{{site.FLINK_VERSION_SHORT }}-WordCount.jar \
-a 1 hdfs:///..../apache-license-v2.txt hdfs:///.../wordcount-result.txt
To:
./bin/flink run ./examples/flink-java-examples-{{site.FLINK_VERSION_SHORT }}-WordCount.jar \
hdfs:///..../apache-license-v2.txt hdfs:///.../wordcount-result.txt
Looking at http://ci.apache.org/projects/flink/flink-docs-master/cli.html seemed like -j and -a are no longer valid?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/flink fix_doc_run_onyarn_params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #482
----
commit 1ae0c5779b0c8b64feb9fd5f00b51a9b83cd4e0e
Author: Henry Saputra <he...@gmail.com>
Date: 2015-03-12T23:18:03Z
Remove -j and -a parameters which seemed no longer valid in the doc example
for submit job to Flink run in YARN.
From:
./bin/flink run -j ./examples/flink-java-examples-{{site.FLINK_VERSION_SHORT }}-WordCount.jar \
-a 1 hdfs:///..../apache-license-v2.txt hdfs:///.../wordcount-result.txt
To:
./bin/flink run ./examples/flink-java-examples-{{site.FLINK_VERSION_SHORT }}-WordCount.jar \
hdfs:///..../apache-license-v2.txt hdfs:///.../wordcount-result.txt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-78868258
Its true, the parameters are not necessarily needed, but they don't harm either. In fact, I like it to explicitly specify parameters. I do not see a need to break the API of the CLI client or a substantial gain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-79140904
Thanks for the input @fhueske. I am trying to make all the example consistent and removing the parameters seem to be consistent with examples in the command line page.
So if no more objection I could merge the change EOD.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-82475999
Looks like failure nothing to do with the commit. Will merge this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra closed the pull request at:
https://github.com/apache/flink/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-78991357
The issue is that those params are not in command line doc. Or maybe I
misread ?
Removing unnecessary param will make it easier to read.
On Friday, March 13, 2015, Fabian Hueske <no...@github.com> wrote:
> Its true, the parameters are not necessarily needed, but they don't harm
> either. In fact, I like it to explicitly specify parameters. I do not see a
> need to break the API of the CLI client or a substantial gain.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/482#issuecomment-78868258>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-78858625
You can still use the `-a` and `-j` arguments. But its certainly nicer to just specify the name of the jar file and the arguments.
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-82530221
I think this should go in. The simple the parameter style the better. And without flags (just with arguments) reads easier, as far as I am concerned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-78996549
No, you are right. These parameters are not in the documentation, not even in the initial import (June last year). I just got used to them ;-)
I still like the explicit parameter style, but since this change is not really an API breaking (except for very early users like me), I'm +-0 for the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-82605275
This is merged by @StephanEwen with http://git-wip-us.apache.org/repos/asf/flink/commit/72ca014e.
Thanks Stephan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---