You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/02/07 05:24:00 UTC
[PR] Avoid using `org.graalvm.polyglot.Value.toString()` in EspressoInlineExpressionParser [shardingsphere]
linghengqian opened a new pull request, #30038:
URL: https://github.com/apache/shardingsphere/pull/30038
For #30026.
Changes proposed in this pull request:
- Avoid using `org.graalvm.polyglot.Value.toString()` in EspressoInlineExpressionParser. The call to `toString()` seems to be due to a limitation of early graal-sdk, where the String should be fetched directly from the guest JVM.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor InlineExpressionParser to prevent exposing Groovy API [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #30038:
URL: https://github.com/apache/shardingsphere/pull/30038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org