You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/05/06 05:21:39 UTC
[GitHub] [incubator-livy] akitanaka commented on issue #170: [LiVY-590] Add
dependency to jersey-core
akitanaka commented on issue #170: [LiVY-590] Add dependency to jersey-core
URL: https://github.com/apache/incubator-livy/pull/170#issuecomment-489503539
Hello. As far as I tested locally, the the ITs fails when livy-server has ``jersey-core 1.19``. If the package does not have ``jersey-core`` or it has ``jersey-core 1.9``, the test succeeded.
Since a thrift/client jar/path is never used in the server side, I think we can have a different jersey-core version for livy-server and thrift/client. Also, livy-server should have a same version of jersey-core package that hadoop-common has. So, I think we should specify jersey-core version in thrift/client and not livy-server.
I updated my pull request, now livy-server has ``jersey-core 1.9`` (The version is defined by hadoop-common) and thrift/client has ``jersey-core 1.19``.
* default
```
[ec2-user@ip-10-0-2-216 incubator-livy]$ find|grep jersey-core
./thriftserver/client/target/jars/jersey-core-1.9.jar
```
\# In my environment, jersey-core version is 1.9 and not 1.19.
* remove exclustion for jersey-core in server/pom.xml
```
[ec2-user@ip-10-0-2-216 incubator-livy]$ find|grep jersey-core
./server/target/jars/jersey-core-1.9.jar
./thriftserver/client/target/jars/jersey-core-1.9.jar
```
* add jersey-core version to thrift/client
```
[ec2-user@ip-10-0-2-216 incubator-livy]$ find|grep jersey-core
./server/target/jars/jersey-core-1.9.jar
./thriftserver/client/target/jars/jersey-core-1.19.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services