You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/04 04:36:22 UTC
[GitHub] [airflow] maxirus opened a new pull request #7357: [AIRFLOW-6273]
Fixes Databricks Connection when using Token
maxirus opened a new pull request #7357: [AIRFLOW-6273] Fixes Databricks Connection when using Token
URL: https://github.com/apache/airflow/pull/7357
Fixes the Databricks connection when using an Auth Token. Token can be stored in a password and follows the general connection schema.
Also fixes [AIRFLOW-6174](https://issues.apache.org/jira/browse/AIRFLOW-6174)
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x ] Description above provides context of the change
- [x ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x ] Unit tests coverage for changes (not needed for documentation changes)
- [x ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x ] Relevant documentation is updated including usage instructions.
- [ x ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] commented on issue #7357: [AIRFLOW-6273] Fixes
Databricks Connection when using Token
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #7357: [AIRFLOW-6273] Fixes Databricks Connection when using Token
URL: https://github.com/apache/airflow/pull/7357#issuecomment-601794029
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] RosterIn commented on a change in pull request #7357:
[AIRFLOW-6273] Fixes Databricks Connection when using Token
Posted by GitBox <gi...@apache.org>.
RosterIn commented on a change in pull request #7357: [AIRFLOW-6273] Fixes Databricks Connection when using Token
URL: https://github.com/apache/airflow/pull/7357#discussion_r374744638
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -147,13 +148,32 @@ def _do_api_call(self, endpoint_info, json):
"""
method, endpoint = endpoint_info
- if 'token' in self.databricks_conn.extra_dejson:
- self.log.info('Using token auth. ')
+ # Note: host/auth logic made more complicated to maintain
+ # backward compatibility with this commit:
+ # https://github.com/apache/airflow/pull/5635
+ if self.databricks_conn.password[0:4] == "dapi":
+ self.log.info('Using token auth.')
+ auth = _TokenAuth(self.databricks_conn.password)
+ # DEPRECATED: Will be removed in a future release
+ elif 'token' in self.databricks_conn.extra_dejson:
+ warnings.warn(
+ "Found token in extras. This will be deprecated in a future release. Use password field instead.",
Review comment:
Why not adding a new field to the connection called token?
This way when adding the connection users will add the token in it's own field rather than the extra. Asking them to put token in password isn't explicit. Probably most won't do it and will have to fix once warning is raised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] closed pull request #7357: [AIRFLOW-6273]
Fixes Databricks Connection when using Token
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #7357: [AIRFLOW-6273] Fixes Databricks Connection when using Token
URL: https://github.com/apache/airflow/pull/7357
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services