You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2018/01/17 23:44:10 UTC
[GitHub] madlib pull request #227: Add docker file for postgres 9.6 and 10
GitHub user orhankislal opened a pull request:
https://github.com/apache/madlib/pull/227
Add docker file for postgres 9.6 and 10
- install plpython support for postgres
- add dockerfile for postgres 10 centos 7
- add postgres bin dir to $PATH for both 9.6 and 10
- remove unnecessary files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/madlib centos_postgres_docker
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #227
----
commit 81a634ad16f53f1de2afe2f768bcb059493c8313
Author: Nikhil Kak <nk...@...>
Date: 2017-11-09T22:54:01Z
Add docker file for postgres 9.6 and 10
- install plpython support for postgres
- add dockerfile for postgres 10 centos 7
- add postgres bin dir to $PATH for both 9.6 and 10
- remove unnecessary files
----
---
[GitHub] madlib pull request #227: Add docker file for postgres 9.6 and 10
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/227#discussion_r162219833
--- Diff: tool/docker/base/Dockerfile_postgres_9_6 ---
@@ -1,71 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-FROM postgres:9.6
-
-### Get postgres specific add-ons
-RUN apt-get update && apt-get install -y wget \
- build-essential \
- postgresql-server-dev-9.6 \
- postgresql-plpython-9.6 \
- openssl \
- libssl-dev \
- libboost-all-dev \
- m4 \
- wget \
- vim \
- pgxnclient \
- flex \
- bison \
- graphviz
-
-### Build custom CMake with SSQL support
-RUN wget https://cmake.org/files/v3.6/cmake-3.6.1.tar.gz && \
- tar -zxvf cmake-3.6.1.tar.gz && \
- cd cmake-3.6.1 && \
- sed -i 's/-DCMAKE_BOOTSTRAP=1/-DCMAKE_BOOTSTRAP=1 -DCMAKE_USE_OPENSSL=ON/g' bootstrap && \
- ./configure && \
- make -j2 && \
- make install
-
-### Install doxygen-1.8.13:
-RUN wget http://ftp.stack.nl/pub/users/dimitri/doxygen-1.8.13.src.tar.gz && \
- tar xf doxygen-1.8.13.src.tar.gz && \
- cd doxygen-1.8.13 && \
- mkdir build && \
- cd build && \
- cmake -G "Unix Makefiles" .. && \
- make && \
- make install
-
-### Optional: install LaTex
-### uncomment the following 'RUN apt-get' line to bake LaTex into the image
-### Note: if you run the following line, please tag the image as
-### madlib/postgres_9.6:LaTex, and don't tag it as latest
-# RUN apt-get install -y texlive-full
--- End diff --
Please retain this comment too in the new docker files. `texlive-full` is big to have it as part of the image, so developers can refer to this to figure out the exact command to install latex. It is required to build the design doc.
---
[GitHub] madlib issue #227: Add docker file for postgres 9.6 and 10
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:
https://github.com/apache/madlib/pull/227
Created a new pull request (#228). Closing this one.
---
[GitHub] madlib issue #227: Add docker file for postgres 9.6 and 10
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/227
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/326/
---
[GitHub] madlib pull request #227: Add docker file for postgres 9.6 and 10
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal closed the pull request at:
https://github.com/apache/madlib/pull/227
---
[GitHub] madlib pull request #227: Add docker file for postgres 9.6 and 10
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/227#discussion_r162219624
--- Diff: tool/docker/base/Dockerfile_postgres_9_6 ---
@@ -1,71 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-FROM postgres:9.6
-
-### Get postgres specific add-ons
-RUN apt-get update && apt-get install -y wget \
- build-essential \
- postgresql-server-dev-9.6 \
- postgresql-plpython-9.6 \
- openssl \
- libssl-dev \
- libboost-all-dev \
- m4 \
- wget \
- vim \
- pgxnclient \
- flex \
- bison \
- graphviz
--- End diff --
We should keep `flex`, `bison`, and `graphviz` in `Dockerfile_centos_7_postgres_9_6` to help developers build docs using the docker image.
---
[GitHub] madlib pull request #227: Add docker file for postgres 9.6 and 10
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/227#discussion_r162219538
--- Diff: tool/docker/base/Dockerfile_postgres_9_6 ---
@@ -1,71 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-FROM postgres:9.6
-
-### Get postgres specific add-ons
-RUN apt-get update && apt-get install -y wget \
- build-essential \
- postgresql-server-dev-9.6 \
- postgresql-plpython-9.6 \
- openssl \
- libssl-dev \
- libboost-all-dev \
- m4 \
- wget \
- vim \
- pgxnclient \
- flex \
- bison \
- graphviz
-
-### Build custom CMake with SSQL support
-RUN wget https://cmake.org/files/v3.6/cmake-3.6.1.tar.gz && \
- tar -zxvf cmake-3.6.1.tar.gz && \
- cd cmake-3.6.1 && \
- sed -i 's/-DCMAKE_BOOTSTRAP=1/-DCMAKE_BOOTSTRAP=1 -DCMAKE_USE_OPENSSL=ON/g' bootstrap && \
- ./configure && \
- make -j2 && \
- make install
-
-### Install doxygen-1.8.13:
-RUN wget http://ftp.stack.nl/pub/users/dimitri/doxygen-1.8.13.src.tar.gz && \
- tar xf doxygen-1.8.13.src.tar.gz && \
- cd doxygen-1.8.13 && \
- mkdir build && \
- cd build && \
- cmake -G "Unix Makefiles" .. && \
- make && \
- make install
--- End diff --
We should probably keep this in the new docker files.
These are required for `make doc` on the docker image. It is a convenient way of building docs for developers.
---